Date: Tue, 21 Mar 2017 10:06:11 -0600 From: Stephen Mcconnell <stephen.mcconnell@broadcom.com> To: John <jwd@freebsd.org>, FreeBSD-SCSI <freebsd-scsi@freebsd.org>, scottl@freebsd.org Subject: RE: mpr driver allocating 1 irq? Message-ID: <abb63f1981574dc4968c9f5cb232d735@mail.gmail.com> In-Reply-To: <20170321140144.GA25836@FreeBSD.org> References: <20170321140144.GA25836@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think the problem is that there is no improvement when using MSIx. scottl@ was working on a finer grained locking mechanism that would help. Maybe he can comment. Steve > -----Original Message----- > From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd- > scsi@freebsd.org] On Behalf Of John > Sent: Tuesday, March 21, 2017 8:02 AM > To: FreeBSD-SCSI > Subject: mpr driver allocating 1 irq? > > Hi Folks, > > The following define is in sys/dev/mpr/mprvar.h: > > #define MPR_MSI_COUNT 1 > > Is there a particular reason it's hard-coded to 1 and not a tunable? > > if ((sc->disable_msix == 0) && > ((msgs = pci_msix_count(dev)) >= MPR_MSI_COUNT)) > error = mpr_alloc_msix(sc, MPR_MSI_COUNT); > > Or am I completely misreading the code? > > The code appears to support a value other than 1. > > Thanks, > John > > with verbose=1: > > mpr0: attempting to allocate 1 MSI-X vectors (96 supported) > mpr1: attempting to allocate 1 MSI-X vectors (96 supported) > mpr2: attempting to allocate 1 MSI-X vectors (96 supported) > mpr3: attempting to allocate 1 MSI-X vectors (96 supported)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?abb63f1981574dc4968c9f5cb232d735>