Date: Thu, 14 Feb 2013 09:17:21 -0500 From: "Mikhail T." <mi+thun@aldan.algebra.com> To: Tom Evans <tevans.uk@googlemail.com> Cc: Kimmo Paasiala <kpaasial@gmail.com>, "free >> Current FreeBSD" <freebsd-current@freebsd.org>, "O. Hartmann" <ohartman@zedat.fu-berlin.de>, Ports FreeBSD <freebsd-ports@freebsd.org>, Yamaya Takashi <yamayan@kbh.biglobe.ne.jp> Subject: Re: ports include /etc/src.conf? i.e. graphics/libfpx Message-ID: <511CF1F1.5070204@aldan.algebra.com> In-Reply-To: <CAFHbX1KJ9eDYa4UiZ5N53EEnF1dPmq13F-SvRaKyr=AJYdb79A@mail.gmail.com> References: <511B662C.7030602@zedat.fu-berlin.de> <511B874A.7080901@kbh.biglobe.ne.jp> <CAFHbX1Lg4w8g30DrcEbvm%2B6sFvTDpRAt7OouBBBUs1iiMaEL5g@mail.gmail.com> <CA%2B7WWSfOHnYow56BggaG6_T8hGY9GZKTzuT_E7=LWex2Th0XQQ@mail.gmail.com> <511BBDAD.1080806@zedat.fu-berlin.de> <511CD83C.107@aldan.algebra.com> <CAFHbX1LKuDbKYSifFDsRYhc3eCd5g7c-ifAHF9jMSjqow6kVVA@mail.gmail.com> <511CE2AD.8050506@aldan.algebra.com> <CAFHbX1KJ9eDYa4UiZ5N53EEnF1dPmq13F-SvRaKyr=AJYdb79A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
14.02.2013 08:55, Tom Evans написав(ла):
> On Thu, Feb 14, 2013 at 1:12 PM, Mikhail T. <mi+thun@aldan.algebra.com> wrote:
>> > I may sound defensive here, but I'll still repeat, that "this singular port"
>> > (and I do, in fact, have other ones like it) started using bsd.lib.mk 5
>> > years before src.conf (and its man-page) was added to the tree.
>>
> This is true. But what is the bug, that the port's Makefile.bsd was
> not updated on the introduction of src.conf to DTRT (and no-one
> noticed for 7 years), or that the purpose of src.conf has been
> mistakenly documented for 7 years?
I think, the bug is either in documentation or implementation of
src.conf (if it had to be implemented at all, that is) -- there was
never (and still is not) any suggestion, that bsd.{prog,lib}.mk are not
supposed to be used by other people's software.
Maybe, if the file is really meant to be used by *world and *kernel
targets, the knob should've been _WITH_SRCONF -- and added to the
environment by src/Makefile? Because, forget ports for a second, what if
my own little project uses bsd.prog.mk -- because Makefiles using it
tend to fit in a window without scrolling?
I'd say, the documentation should be updated to state, that src.conf
will affect anything, that uses bsd.*.mk family of makefiles, unless
_WITHOUT_SRCCONF is set. The entire /usr/src as well as "some of the
ports" may then be listed as examples of the areas affected. This will
reflect reality and help avoid frustration that O. Hartmann went through.
-mi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?511CF1F1.5070204>