Date: Wed, 29 Nov 2000 14:38:33 -0500 From: Jonathan Chen <jon@spock.org> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: Jonathan Chen <jon@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cardbus cardbus_cis.c cardbus_cis.h cardbusreg.h Message-ID: <20001129143833.D40023@spock.org> In-Reply-To: <200011291650.eATGoh438340@aslan.scsiguy.com>; from gibbs@scsiguy.com on Wed, Nov 29, 2000 at 09:50:43AM -0700 References: <200011291608.eATG81e92298@freefall.freebsd.org> <200011291650.eATGoh438340@aslan.scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 29, 2000 at 09:50:43AM -0700, Justin T. Gibbs wrote:
> >jon 2000/11/29 08:08:01 PST
> >
> > Modified files:
> > sys/dev/cardbus cardbus_cis.c cardbus_cis.h cardbusreg.h
> > Log:
> > Oops, broke CIS reading from ROM on my last commit.
> > This should fix it.
>
> I know that you're pressed for time, but can you provide more detail
> in your commit messages? I saw that some of the changes I proposed were
> included in your last checkin, but neither their inclusion nor their
> rationale made it into the logs.
Sorry, I was in a rush to get this in before I have to leave for a root
canal. Basically, that was me realizing "cardbus_read_exrom_cis() failed
to advance correctly to higer rom images. To effect the fix, the cis_ptr
value must be provided to the different CIS reading methods, unaltered."
Unfortunately, a couple of the original bugs made it through to this new
revision because I haven't had time to check a pccard reference and comb
through your proposed changes. Justin, please let me know if the new
changes fixes the problems.
--
(o_ 1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2 _o)
\\\_\ Jonathan Chen jon@spock.org /_///
<____) No electrons were harmed during production of this message (____>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001129143833.D40023>