Date: Fri, 9 Jan 2004 19:11:19 -0500 From: "Adam C. Migus" <adam@migus.org> To: ports@freebsd.org Subject: textproc/p5-XML-LibXML broken, why? Message-ID: <200401091911.19186.adam@migus.org>
next in thread | raw e-mail | index | archive | help
su-2.05b# uname -a
FreeBSD ludo.migus.org 5.1-RELEASE-p10 FreeBSD 5.1-RELEASE-p10 #5: Sat
Oct 25 23:51:05 EDT 2003
amigus@ludo.migus.org:/obj/freebsd/sys/src/freebsd/RELENG_5_1/src/sys/SMP_FAST
i386
su-2.05b# pwd
/src/freebsd/ports/textproc/p5-XML-LibXML
su-2.05b# make
===> p5-XML-LibXML-1.56 is marked as broken: Does not compile on
FreeBSD 501000.
su-2.05b#
I attempted to locate the error in the bento logs but the log file's
gone so I'm not entirely sure why it's broken but when I remove the
broken marking from Makefile it compiles however I get the following
warnings under both FreeBSD and NetBSD:
LibXML.xs:73: warning: duplicate `extern'
LibXML.xs:74: warning: duplicate `extern'
LibXML.xs:76: warning: duplicate `extern'
LibXML.xs:77: warning: duplicate `extern'
LibXML.xs:78: warning: duplicate `extern'
LibXML.xs:79: warning: duplicate `extern'
Is this the reason it was marked as broken?
The following patch removes them:
diff -Nru --exclude=CVS p5-XML-LibXML.orig/Makefile
p5-XML-LibXML/Makefile
--- p5-XML-LibXML.orig/Makefile Tue Dec 23 01:50:53 2003
+++ p5-XML-LibXML/Makefile Fri Jan 9 18:49:32 2004
@@ -36,8 +36,4 @@
.include <bsd.port.pre.mk>
-.if ${OSVERSION} >= 500113
-BROKEN= "Does not compile on FreeBSD ${OSVERSION}"
-.endif
-
.include <bsd.port.post.mk>
diff -Nru --exclude=CVS p5-XML-LibXML.orig/files/patch-LibXML.xs
p5-XML-LibXML/files/patch-LibXML.xs
--- p5-XML-LibXML.orig/files/patch-LibXML.xs Wed Dec 31 19:00:00 1969
+++ p5-XML-LibXML/files/patch-LibXML.xs Sat Jan 3 03:27:21 2004
@@ -0,0 +1,23 @@
+--- LibXML.xs.orig 2003-12-22 10:38:06.000000000 -0500
++++ LibXML.xs 2003-12-22 10:38:12.000000000 -0500
+@@ -64,20 +64,6 @@
+ }
+ #endif
+
+-#ifdef VMS
+-extern int xmlDoValidityCheckingDefaultVal;
+-#define xmlDoValidityCheckingDefaultValue
xmlDoValidityCheckingDefaultVal
+-extern int xmlSubstituteEntitiesDefaultVal;
+-#define xmlSubstituteEntitiesDefaultValue
xmlSubstituteEntitiesDefaultVal
+-#else
+-LIBXML_DLL_IMPORT extern int xmlDoValidityCheckingDefaultValue;
+-LIBXML_DLL_IMPORT extern int xmlSubstituteEntitiesDefaultValue;
+-#endif
+-LIBXML_DLL_IMPORT extern int xmlGetWarningsDefaultValue;
+-LIBXML_DLL_IMPORT extern int xmlKeepBlanksDefaultValue;
+-LIBXML_DLL_IMPORT extern int xmlLoadExtDtdDefaultValue;
+-LIBXML_DLL_IMPORT extern int xmlPedanticParserDefaultValue;
+-
+ #define TEST_PERL_FLAG(flag) \
+ SvTRUE(perl_get_sv(flag, FALSE)) ? 1 : 0
+
FWIW I contacted the perl package maintainer some time ago and got no
response. The cvs log for the port indicates that the port maintainer
was contacted. Can this patch be put in place to unbreak the port
until such a time as someone comes up with a better fix?
--
Adam C. Migus - http://people.migus.org/~amigus/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401091911.19186.adam>