Date: Fri, 20 May 2016 21:13:01 +0530 From: "Kristof Provost" <kp@FreeBSD.org> To: Max <maximos@als.nnov.ru> Cc: freebsd-pf@FreeBSD.org Subject: Re: fragments processing Message-ID: <1D01E770-1FE5-4CCF-9D5F-91FB8ADE955D@FreeBSD.org> In-Reply-To: <856294d7-a71c-811b-cc3e-31b81af2d79c@als.nnov.ru> References: <93ccf602-31d6-fe36-4ccc-96ab1a1e2cc1@als.nnov.ru> <0ED6BC86-1DDF-4C80-9C05-6ED19049AB92@FreeBSD.org> <856294d7-a71c-811b-cc3e-31b81af2d79c@als.nnov.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 May 2016, at 18:57, Max wrote: > 20.05.2016 11:53, Kristof Provost пишет: >> On 19 May 2016, at 19:49, Max wrote: >>> The number of used frags (almost) never decreases. I don't have >>> enough experience in programming. But I guess that the problem may >>> be in "frag->fr_timeout = time_second;" in pf_fillup_fragment() >>> (pf_norm.c). It should be "frag->fr_timeout = time_uptime;". >>> Actually, I don't now the difference between those variables. So, >>> correct me if I'm wrong. >>> >> I think you’re right. If I’m reading the code right time_second >> is unix time, >> but time_uptime is the number of seconds the system has been up. > > I rebuilt the kernel. It seems the problem is gone. > Awesome, thanks for testing. I’ve committed the fix, and will merge it back to stable/10 in a couple of days. Regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1D01E770-1FE5-4CCF-9D5F-91FB8ADE955D>