Date: Tue, 9 Sep 2025 19:42:40 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Jamie Gritton <jamie@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 16f600dc30b7 - main - jaildesc: replace EBADF with EINVAL Message-ID: <9B159FF1-8D1D-4F1D-9CED-977EB0834403@freebsd.org> In-Reply-To: <202509091818.589II2D2005924@gitrepo.freebsd.org> References: <202509091818.589II2D2005924@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 Sep 2025, at 19:18, Jamie Gritton <jamie@freebsd.org> wrote: >=20 > The branch main has been updated by jamie: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D16f600dc30b7bb82429660e540da802a= 1e3f7449 >=20 > commit 16f600dc30b7bb82429660e540da802a1e3f7449 > Author: Jamie Gritton <jamie@FreeBSD.org> > AuthorDate: 2025-09-09 18:13:11 +0000 > Commit: Jamie Gritton <jamie@FreeBSD.org> > CommitDate: 2025-09-09 18:13:11 +0000 >=20 > jaildesc: replace EBADF with EINVAL >=20 > Following fd9e09cb, EBADF is not the suitable error code for a non- > jail descriptor passed to jail_set, jail_get, jail_attach_fd, and > jail_remove_fd. >=20 > Reported by: kib Will you be MFC=E2=80=99ing this fix, the error checking one and any = future fixes to the new jaildesc code? The original jaildesc commit made it in in time for stable/15 so will be part of 15.0, so either important fixes need to be MFC=E2=80=99ed to ensure we release something without = bugs or it should be reverted in stable/15 and the whole series later MFC=E2=80=99= ed once deemed ready. Especially given the discussion about file object ownership I=E2=80=99m a bit concerned that we have something in = stable/15 that has a design, rather than implementation, aspect that might be wrong, and we really don=E2=80=99t want to be shipping a broken syscall ABI if = so. Jessica
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9B159FF1-8D1D-4F1D-9CED-977EB0834403>