Date: Mon, 17 Oct 2016 19:01:50 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files Message-ID: <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org> In-Reply-To: <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <d8557129-7ede-8ba7-7b8e-8745563930a2@marino.st> <b09dc39e-1656-5f35-cf72-bb4469d350b6@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--PNSEcMtdkMjOg2JBxOTM3vHLxXQqHVhvl
Content-Type: multipart/mixed; boundary="Hg4rOF3B1t14ko7jUKFXJipKxVXimTx7p";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: marino@freebsd.org, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org>
Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk
spice-gtk/files
References: <201610171515.u9HFF8pG092481@repo.freebsd.org>
<1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org>
<d8557129-7ede-8ba7-7b8e-8745563930a2@marino.st>
<b09dc39e-1656-5f35-cf72-bb4469d350b6@FreeBSD.org>
<53c293a4-cc69-53dc-5311-54393b2f9249@marino.st>
<704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org>
<74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st>
In-Reply-To: <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st>
--Hg4rOF3B1t14ko7jUKFXJipKxVXimTx7p
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Le 17/10/2016 =C3=A0 18:31, John Marino a =C3=A9crit :
>
>
> On 10/17/2016 11:28, Mathieu Arnold wrote:
>> Le 17/10/2016 =C3=A0 18:26, John Marino a =C3=A9crit :
>>> On 10/17/2016 11:20, Mathieu Arnold wrote:
>>>> Le 17/10/2016 =C3=A0 17:55, John Marino a =C3=A9crit :
>>>>> On 10/17/2016 10:52, Mathieu Arnold wrote:
>>>>>> Le 17/10/2016 =C3=A0 17:15, John Marino a =C3=A9crit :
>>>>>>> Apparently USES=3Dpathfix and USES=3Dautoreconf can't be used
>>>>>>> together, so
>>>>>>> the pkgconfig directory is now passed via MAKE_ARGS
>>>>>>
>>>>>> That is mostly not true. What usage makes it so that they do not
>>>>>> work
>>>>>> together ?
>>>>>
>>>>> The results suggest that "${WRKSRC}/configure" was modified, then
>>>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that the
>>>>> pkgconfig path change was reverted.
>>>>>
>>>>> That's why I had to replace pathfix with MAKE_ARGS.
>>>>
>>>> No, USES=3Dpathfix changes the content of PATHFIX_MAKEFILEIN, which =
by
>>>> default, is Makefile.in. It won't change configure unless you set
>>>> PATHFIX_MAKEFILEIN=3Dconfigure.
>>>>
>>>
>>> Well, I didn't add MAKE_ARGS for fun.
>>> After adding USES+=3Dautoreconf, the build broke. pathfix was still =
in
>>> place. You can reproduce by adding pathfix back before "python" and
>>> commenting out the new MAKE_ARGS line I added and check with
>>> "check-plist" It's easy to confirm.
>>
>> I never said your fix did not work or was not right, I said USES=3Dpat=
hfix
>> won't touch configure.
>>
>
> Ah, that's the issue. I misspoke. I didn't mean "configure", I mean
> the Makefile all along. So you agree in this case pathfix and
> autoreconf aren't compatible, right?
Not at all, if the file patched was Makefile.in, set
PATHFIX_MAKEFILEIN=3DMakefile.am and it will work.
--=20
Mathieu Arnold
--Hg4rOF3B1t14ko7jUKFXJipKxVXimTx7p--
--PNSEcMtdkMjOg2JBxOTM3vHLxXQqHVhvl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJYBQQAXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85INp0QAI4jRXg9DqhYK4HC01OzdO0+
ssR2rhljrHyq+L7gxBK/4Ls4HrnDtYipiFqdf5rv3cuwPlGJWYVoj4FTJOSSIAqU
MJsKldA8sMFGl1DiNq40tG+NCHJnXrkeXdaqVWMO4fJncP9ABdhQ/35e9aRH4P29
UE8iJd/4fNVuvc2DPKBGlKHpUobNfdDFlRnOg/3B16O49s8KWEnAP6srZpgBeRms
gBKUjjq2pV8vckW+Sh0dOXbq6p42ebB6WHIksQfvIvuSmN5rJibheRvRTC4//lD3
pEUJlTCcDg7AWDODDW6hf4B8jdcACDRu9fCxV2B1Fl7anw21WIEZmhgJ/U9tnaHB
cqNKVoyOWCEMd0EnDubyb2mOF30p0N1KRRkWLgTwW/HwJIN/yuKqIIGy100C3aRr
oJFmv25l2ha6XtibZal7Rkt62teh82a8+o2Qg5yMcNXkSU6iS1MPFF1tmkVHqrjo
26qytea0CmEw7Gi9R/tbhgklM2kEdQdc5sId1XRusrr0+pQg3nATst+XY2oHcf5P
SrVzS4RPGMhdzAQKzBzSOWZInVorpsnDJgguxFGZtV7/VlWSDbRsvKhRLBKG0I0k
83Co73oOQCPUVA1pVQcpYGNNPpup9ieBb3oOF27XKq6q3Md+vszdkP8kk7fn0EFb
wkTpu1k+gqum7F6JQSai
=5DA1
-----END PGP SIGNATURE-----
--PNSEcMtdkMjOg2JBxOTM3vHLxXQqHVhvl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5a37eec4-7703-d0d9-f82e-393e1dd6543a>