Date: Tue, 21 Mar 2017 01:44:17 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Hans Petter Selasky <hselasky@FreeBSD.org> Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt Message-ID: <E0FF4CB1-5D60-4B2F-B254-F42909DB1119@gmail.com> In-Reply-To: <0D2EB76A-146A-4679-8C56-2A84AFFE1822@gmail.com> References: <201703210639.v2L6dnRf055522@repo.freebsd.org> <0D2EB76A-146A-4679-8C56-2A84AFFE1822@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_73FC7939-9E0A-4A14-81AE-A87D3D9BC12E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Mar 21, 2017, at 01:42, Ngie Cooper (yaneurabeya) = <yaneurabeya@gmail.com> wrote: >=20 >>=20 >> On Mar 20, 2017, at 23:39, Gleb Smirnoff <glebius@freebsd.org> wrote: >>=20 >> Author: glebius >> Date: Tue Mar 21 06:39:49 2017 >> New Revision: 315662 >> URL: https://svnweb.freebsd.org/changeset/base/315662 >>=20 >> Log: >> Hide struct inpcb, struct tcpcb from the userland. >>=20 >> This is a painful change, but it is needed. On the one hand, we = avoid >> modifying them, and this slows down some ideas, on the other hand we = still >> eventually modify them and tools like netstat(1) never work on next = version of >> FreeBSD. We maintain a ton of spares in them, and we already got = some ifdef >> hell at the end of tcpcb. >>=20 >> Details: >> - Hide struct inpcb, struct tcpcb under _KERNEL || _WANT_FOO. >> - Make struct xinpcb, struct xtcpcb pure API structures, not = including >> kernel structures inpcb and tcpcb inside. Export into these = structures >> the fields from inpcb and tcpcb that are known to be used, and put = there >> a ton of spare space. >> - Make kernel and userland utilities compilable after these changes. >> - Bump __FreeBSD_version. >>=20 >> Reviewed by: rrs, gnn >> Differential Revision: D10018 >=20 > This change broke the sdp module: = https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/2294/console . > Thanks, > -Ngie It also broke gcc buildworld: = https://ci.freebsd.org/job/FreeBSD-head-sparc64-build/47/console . Thanks, -Ngie --Apple-Mail=_73FC7939-9E0A-4A14-81AE-A87D3D9BC12E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY0OfhAAoJEPWDqSZpMIYVtbcP/3HET4HACQTkYWlhWCxJnR8T B3recApLMTdA+I+RwfClD4z1GvKrbDGY7MU/Qz/Ozz038/qJApCIa2dYadzwzUiy ZdFLRLuVKa8Y/bhCQzLgktHi/bIjWdIqP+w0Xz2MYcgXGtGyKm5MBgmknZpC1txE 5kkOBOmY2YVXIBFOtEfhhAVEl7FYwP7DnFNhAmBlrLKNzYK+e9hmiYQue3N8SGoB RYF3yP2PsG6U84lRJgo7DJEMX3zi3vHE39BwyuPgog7ZrECBxekrWfodvmuEK7+v brR1s41+50Bk4nfeZk/0c+hwC6d76npOZF7xZmbxT5/pA3Q/QHJBEfeys2Ki1J21 fkhk7njI8dKxZ9TZcAeiHT/rYdHKwG+6dSjtOz2ZJQoyfM14To1NyPXqfE2xWPj8 +FQvu4lgv13dOJXbOX7zTwORclsXJE7WVPT0zT+yQlDYdjvkVzhoszYRAoPvWy5w UDnUBbEoGDLxMqkMIsKkgTpp/7VHa6EZYFxzvqrbohHt60yXkqx+Cu1qZlJnJKbJ ewY2ZbeMXe6KCuiSHg3AdDc+ps/YwYrpouekrzZcyaXHzfenGHt9TNTfyH+Mux4g L6ZmalM065hp4GvHsI/+LXLpkDgGCXT4ZH0UjCgODYR1krq/SAuQFzuVdcKAcgL1 k3wQeiDS/7BadZpFXZMB =xFn8 -----END PGP SIGNATURE----- --Apple-Mail=_73FC7939-9E0A-4A14-81AE-A87D3D9BC12E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E0FF4CB1-5D60-4B2F-B254-F42909DB1119>