Date: Fri, 15 Nov 2019 15:10:21 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Enji Cooper <ngie@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python <python@FreeBSD.org> Subject: Re: svn commit: r517602 - head/devel/py-mock Message-ID: <5b6c8282-cbb4-d852-8260-95d7896c91e4@FreeBSD.org> In-Reply-To: <imnl-250s-wny@FreeBSD.org> References: <201911141711.xAEHBwBO077712@repo.freebsd.org> <6f252ffe-9e8d-3bb7-fe48-baccda10012d@FreeBSD.org> <imnl-250s-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15/11/2019 2:27 pm, Jan Beich wrote:
> Kubilay Kocak <koobs@FreeBSD.org> writes:
>
>> The canonical pytest invocation is:
>>
>> cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=
>
> For a canonical it is uncommon. Besides, you've made mistakes:
> - No braces around `cd` compared to what Porter's Handbook recommends
> - No TEST_ENV in case tests need TZ=UTC, LANG=en_US.UTF-8, etc.
>
I wasn't being perfectly compliant to focus on the pytest specific
invocation elements. Of course, framework mechanisms should be used
where appropriate and it is recommended to do so.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5b6c8282-cbb4-d852-8260-95d7896c91e4>