Date: Thu, 18 Mar 2010 13:03:48 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Renato Botelho <garga@FreeBSD.org> Cc: eksffa@freebsdbrasil.com.br, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www Makefile ports/www/thundercache Makefile distinfo pkg-descr pkg-plist ports/www/thundercache/files log.sh.in pkg-message.in thunder-rcNG.in Message-ID: <4BA28724.9030200@FreeBSD.org> In-Reply-To: <4BA285D6.7070603@FreeBSD.org> References: <201003181835.o2IIZKkZ059859@repoman.freebsd.org> <4BA285D6.7070603@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mail to maintainer bounces, Renato, are you in contact with him? Doug On 03/18/10 12:58, Doug Barton wrote: > There are numerous problems with this port, starting with the fact that > it installs (most?) everything into /usr/local/thunder. However I've > attached a patch that fixes the rc.d-related stuff at least. > > 1. It's rc.d, not rcng > 2. All new ports that use rc.d scripts need to use the USE_RC_SUBR > mechanism. > 3. The name of the script, PROVIDE, and $name should match the port name. > 4. The script itself wasn't too bad, but I've tidied it up a bit: > a. Added a $FreeBSD$ > b. Added KEYWORD: shutdown since it starts a persistent service. > c. Removed _flags from command=, it's spurious and will result in the > flags being included twice. > d. Moved the default variable assignment to after load_rc_config > e. Made the conf file a required_file, and added it to command_args > instead of _flags. > > The last bit about the conf file isn't strictly necessary, but it has > advantages that I'd be happy to enumerate if there is interest. > > This needs to be fixed sooner rather than later, since I would not want > users to get entrenched with the existing semantics. > > > Doug > > > On 03/18/10 11:35, Renato Botelho wrote: >> garga 2010-03-18 18:35:20 UTC >> >> FreeBSD ports repository >> >> Modified files: >> www Makefile >> Added files: >> www/thundercache Makefile distinfo pkg-descr pkg-plist >> www/thundercache/files log.sh.in pkg-message.in >> thunder-rcNG.in >> Log: >> ThunderCache 4 is an enhaced standalone high-performance web caching system. >> >> It's main goal is to be able to cache dynamic contents, the content most >> proxing systems are unable to do caching. This is how ThunderCache becomes >> high-performance and high-eficiency. >> >> ThunderCache is freeware up to 50 concurrent sessions, and needs commercial >> license to run more than 50 concurrent sessions. It's designed to run on >> FreeBSD. Advanced features include TProxy support (IP_BINDANY), ToS/DiffService >> marking. >> >> WWW: http://www.bmsoftware.org >> >> Submitted by: Patrick Tracanelli <eksffa at freebsdbrasil.com.br> (by email) >> >> Revision Changes Path >> 1.2565 +1 -0 ports/www/Makefile >> 1.1 +82 -0 ports/www/thundercache/Makefile (new) >> 1.1 +6 -0 ports/www/thundercache/distinfo (new) >> 1.1 +27 -0 ports/www/thundercache/files/log.sh.in (new) >> 1.1 +39 -0 ports/www/thundercache/files/pkg-message.in (new) >> 1.1 +21 -0 ports/www/thundercache/files/thunder-rcNG.in (new) >> 1.1 +12 -0 ports/www/thundercache/pkg-descr (new) >> 1.1 +65 -0 ports/www/thundercache/pkg-plist (new) >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/Makefile.diff?&r1=1.2564&r2=1.2565&f=h >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/thundercache/Makefile >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/thundercache/distinfo >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/thundercache/files/log.sh.in >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/thundercache/files/pkg-message.in >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/thundercache/files/thunder-rcNG.in >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/thundercache/pkg-descr >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/thundercache/pkg-plist >> > > > -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BA28724.9030200>