Date: Sun, 24 Apr 2022 02:32:02 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: c08ceddbf735 - main - nda: Fix comment Message-ID: <202204240232.23O2W2TY030931@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=c08ceddbf7352887ed71338f02117d07286ee66c commit c08ceddbf7352887ed71338f02117d07286ee66c Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2022-04-23 23:08:39 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2022-04-24 02:31:46 +0000 nda: Fix comment Fix a comment that was left over from the orignial implementation. Explain how pending transactions in hardware are completed/aborted in the SIM prior to ndacleanup being called. Sponsored by: Netflix --- sys/cam/nvme/nvme_da.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sys/cam/nvme/nvme_da.c b/sys/cam/nvme/nvme_da.c index 84270143cbe6..f47a7f9e2271 100644 --- a/sys/cam/nvme/nvme_da.c +++ b/sys/cam/nvme/nvme_da.c @@ -601,9 +601,10 @@ ndaoninvalidate(struct cam_periph *periph) #endif /* - * Return all queued I/O with ENXIO. - * XXX Handle any transactions queued to the card - * with XPT_ABORT_CCB. + * Return all queued I/O with ENXIO. Transactions may be queued up here + * for retry (since we are called while there's other transactions + * pending). Any requests in the hardware will drain before ndacleanup + * is called. */ cam_iosched_flush(softc->cam_iosched, NULL, ENXIO);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204240232.23O2W2TY030931>