Date: Sun, 19 Jan 2025 16:24:12 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 942e8b555262 - main - graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files Message-ID: <23a3b99a51170a06f24f96681b418e74@mail.infomaniak.com> In-Reply-To: <ff56f0441a00205cb6405e827c3f7467@mail.infomaniak.com> References: <202501051538.505FcMKp033044@gitrepo.freebsd.org> <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com> <ff56f0441a00205cb6405e827c3f7467@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1737300252_b897e47a1208bcdbeacbb27744f779ae_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2025-01-05T18:54:50.000+01:00, Daniel Engberg <daniel.engberg.lists@py= ret.net> wrote: >=C2=A0On=C2=A02025-01-05T18:47:02.000+01:00,=C2=A0Dan= iel=C2=A0Engberg >=C2=A0 >=C2=A0<daniel.engberg.lists@pyret.net>=C2= =A0wrote: >=C2=A0 >>=C2=A0=C2=A0On=C2=A02025-01-05T16:38:28.000+01:00,= =C2=A0Dirk=C2=A0Meyer=C2=A0<dinoex@FreeBSD.org> >>=C2=A0=C2=A0 >>=C2= =A0=C2=A0=C2=A0wrote: >>=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0The=C2=A0bran= ch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated=C2=A0by=C2=A0dinoex: >>>= =C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0URL: >>>=C2=A0=C2=A0= =C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0https://cgit.FreeBSD.org/ports/commit/?= id=3D942e8b555262a6e684ef69e96e0036e065fb8211 >>>=C2=A0=C2=A0=C2=A0 >>>= =C2=A0=C2=A0=C2=A0=C2=A0commit=C2=A0942e8b555262a6e684ef69e96e0036e065fb821= 1 >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0Author:=C2=A0Dirk= =C2=A0Meyer=C2=A0<dinoex@FreeBSD.org> >>>=C2=A0=C2=A0=C2=A0 >>>=C2= =A0=C2=A0=C2=A0=C2=A0AuthorDate:=C2=A02025-01-05=C2=A015:38:11=C2=A0+0000= >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0Commit:=C2=A0Dirk= =C2=A0Meyer=C2=A0<dinoex@FreeBSD.org> >>>=C2=A0=C2=A0=C2=A0 >>>=C2= =A0=C2=A0=C2=A0=C2=A0CommitDate:=C2=A02025-01-05=C2=A015:38:11=C2=A0+0000= >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg:= =C2=A0Converts=C2=A0PCD=C2=A0(Kodak=C2=A0Photo=C2=A0CD)=C2=A0image=C2=A0fil= es >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0--- >>>=C2=A0= =C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0graphics/Makefile=C2=A0|=C2=A01= =C2=A0+ >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0graphics/pcdto= jpeg/Makefile=C2=A0|=C2=A033=C2=A0++++++ >>>=C2=A0=C2=A0=C2=A0 >>>= =C2=A0=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg/distinfo=C2=A0|=C2=A03=C2=A0+ = >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg/pkg-d= escr=C2=A0|=C2=A03=C2=A0+ >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2= =A0=C2=A0graphics/pcdtojpeg/pkg-plist=C2=A0|=C2=A0238 >>>=C2=A0=C2=A0= =C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0+++++++++++++++++++++++++++++++++++++++= ++++ >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A05=C2=A0files= =C2=A0changed,=C2=A0278=C2=A0insertions(+) >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0Hi, >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Unfortunately=C2= =A0this=C2=A0appears=C2=A0to=C2=A0be=C2=A0broken=C2=A0in=C2=A0multiple= =C2=A0ways. >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Resulting=C2=A0binary= =C2=A0doesn't=C2=A0work=C2=A0(14.2-RELEASE=C2=A0on=C2=A0amd64): >>=C2= =A0=C2=A0 >>=C2=A0=C2=A0=C2=A0pcdtojpeg=C2=A0BlownJohn.pcd=C2=A0BlownJohn= -pcd-stock.jpeg >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Segmentation=C2= =A0fault=C2=A0(core=C2=A0dumped) >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0pcd= tojpeg=C2=A0-r=C2=A04=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcdtojpeg-5.jpg >= >=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Segmentation=C2=A0fault=C2=A0(core= =C2=A0dumped) >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0pcdtojpeg=C2=A0-r= =C2=A03=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcdtojpeg-5.jpg >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0Segmentation=C2=A0fault=C2=A0(core=C2=A0dumped)= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0pcdtojpeg=C2=A0-r=C2=A05=C2=A0Blown= John.pcd=C2=A0BlownJohn-pcdtojpeg-5.jpg >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0=C2=A0Warning:=C2=A0Could=C2=A0not=C2=A0open=C2=A064Base=C2=A0IPE=C2= =A0file >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0while=C2=A0trying=C2=A0to= =C2=A0process=C2=A0ICE=C2=A0file >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0"/h= ome/diizzy/patches-upstream/IPE/BlownJohn/64BASE/INFO.IC" >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0Segmentation=C2=A0fault=C2=A0(core=C2=A0dumped)= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0While=C2=A0documentation=C2=A0is= =C2=A0provided=C2=A0a=C2=A0note=C2=A0about=C2=A0this=C2=A0during=C2=A0insta= ll >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0would >>=C2=A0=C2=A0 >>=C2= =A0=C2=A0=C2=A0be=C2=A0helpful. >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Imag= e=C2=A0source: >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0https://sembiance.com= /fileFormatSamples/image/pcd/ >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0CXXFLA= GS=C2=A0are=C2=A0dropped=C2=A0due=C2=A0to=C2=A0misspelling >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0https://cgit.freebsd.org/ports/tree/graphics/pcdt= ojpeg/Makefile?id=3D942e8b555262a6e684ef69e96e0036e065fb8211#n23 >>=C2= =A0=C2=A0 >>=C2=A0=C2=A0=C2=A0We=C2=A0likely=C2=A0avoid=C2=A0doing=C2= =A0exercises=C2=A0with=C2=A0tar=C2=A0in=C2=A0post-install >>=C2=A0=C2= =A0sections? >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Please=C2=A0sort=C2= =A0USES=C2=A0and=C2=A0make=C2=A0it=C2=A0a=C2=A0separate=C2=A0sections. >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0I'm=C2=A0not=C2=A0sure=C2=A0if=C2=A0the= =C2=A0claims=C2=A0on=C2=A0the=C2=A0page=C2=A0are=C2=A0still=C2=A0valid= =C2=A0as >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0ImageMagick7 >>=C2=A0= =C2=A0 >>=C2=A0=C2=A0=C2=A0appears=C2=A0to=C2=A0work=C2=A0fine=C2=A0as= =C2=A0long=C2=A0as=C2=A0you=C2=A0set=C2=A0colorspace=C2=A0to=C2=A0sRGB= =C2=A0during >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0conversion. >>=C2= =A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Best=C2=A0regards, >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0Daniel >=C2=A0 >=C2=A0Hi, >=C2=A0 >=C2=A0Might= =C2=A0also=C2=A0add=C2=A0that=C2=A0ffmpeg=C2=A0also=C2=A0seems=C2=A0to= =C2=A0convert=C2=A0without=C2=A0any=C2=A0issues >=C2=A0 >=C2=A0however= =C2=A0the=C2=A0image=C2=A0is=C2=A0rotated=C2=A090=C2=A0degrees. >=C2= =A0 >=C2=A0Best=C2=A0regards, >=C2=A0 >=C2=A0Daniel Hi, Ple= ase respond otherwise this will likely be backed out as it doesn't work.= Best regards, Daniel --_=_swift_1737300252_b897e47a1208bcdbeacbb27744f779ae_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s= ans-serif;font-size:14px;">On 2025-01-05T18:54:50.000+01:00, Daniel Engberg= <<a href=3D"mailto:daniel.engberg.lists@pyret.net" class=3D"defaultMail= Link defaultMailLink">daniel.engberg.lists@pyret.net</a>> wrote:<br></di= v><div class=3D"ik_mail_quote answerContentMessage"><blockquote class=3D"ws= -ng-quote"><pre style=3D"white-space:normal;"><div>On 2025-01-05T18:47:02.0= 00+01:00, Daniel Engberg<br></div><div><<a href=3D"mailto:daniel.engberg= .lists@pyret.net" class=3D"defaultMailLink defaultMailLink">daniel.engberg.= lists@pyret.net</a>> wrote:<br></div><div><br></div><blockquote class=3D= "ws-ng-quote"><div> On 2025-01-05T16:38:28.000+01:00, Dirk Meyer <<a hr= ef=3D"mailto:dinoex@FreeBSD.org" class=3D"defaultMailLink defaultMailLink">= dinoex@FreeBSD.org</a>><br></div><div> <br></div><div> wrote:<br></div><= div> <br></div><blockquote class=3D"ws-ng-quote"><div> The branch main ha= s been updated by dinoex:<br></div><div> <br></div><div> URL:<br></div><= div> <a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" href=3D"https://= cgit.FreeBSD.org/ports/commit/?id=3D942e8b555262a6e684ef69e96e0036e065fb821= 1" class=3D"defaultMailLink defaultMailLink" target=3D"_blank">https://cgit= .FreeBSD.org/ports/commit/?id=3D942e8b555262a6e684ef69e96e0036e065fb8211</a= ><br></div><div> <br></div><div> commit 942e8b555262a6e684ef69e96e0036e0= 65fb8211<br></div><div> <br></div><div> Author: Dirk Meyer <<a href= =3D"mailto:dinoex@FreeBSD.org" class=3D"defaultMailLink defaultMailLink">di= noex@FreeBSD.org</a>><br></div><div> <br></div><div> AuthorDate: 2025= -01-05 15:38:11 +0000<br></div><div> <br></div><div> Commit: Dirk Meyer = <<a href=3D"mailto:dinoex@FreeBSD.org" class=3D"defaultMailLink defaultM= ailLink">dinoex@FreeBSD.org</a>><br></div><div> <br></div><div> Commi= tDate: 2025-01-05 15:38:11 +0000<br></div><div> <br></div><div> graphics= /pcdtojpeg: Converts PCD (Kodak Photo CD) image files<br></div><div> <br><= /div><div> ---<br></div><div> <br></div><div> graphics/Makefile | 1 +<= br></div><div> <br></div><div> graphics/pcdtojpeg/Makefile | 33 ++++++<b= r></div><div> <br></div><div> graphics/pcdtojpeg/distinfo | 3 +<br></div= ><div> <br></div><div> graphics/pcdtojpeg/pkg-descr | 3 +<br></div><div>= <br></div><div> graphics/pcdtojpeg/pkg-plist | 238<br></div><div> ++++= +++++++++++++++++++++++++++++++++++++++<br></div><div> <br></div><div> 5= files changed, 278 insertions(+)<br></div></blockquote><div> <br></div><d= iv> Hi,<br></div><div> <br></div><div> Unfortunately this appears to be bro= ken in multiple ways.<br></div><div> <br></div><div> Resulting binary doesn= 't work (14.2-RELEASE on amd64):<br></div><div> <br></div><div> pcdtojpeg B= lownJohn.pcd BlownJohn-pcd-stock.jpeg<br></div><div> <br></div><div> Segmen= tation fault (core dumped)<br></div><div> <br></div><div> pcdtojpeg -r 4 Bl= ownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></div><div> <br></div><div> Segmen= tation fault (core dumped)<br></div><div> <br></div><div> pcdtojpeg -r 3 Bl= ownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></div><div> <br></div><div> Segmen= tation fault (core dumped)<br></div><div> <br></div><div> pcdtojpeg -r 5 Bl= ownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></div><div> <br></div><div> Warnin= g: Could not open 64Base IPE file<br></div><div> <br></div><div> while tryi= ng to process ICE file<br></div><div> <br></div><div> "/home/diizzy/patches= -upstream/IPE/BlownJohn/64BASE/INFO.IC"<br></div><div> <br></div><div> Segm= entation fault (core dumped)<br></div><div> <br></div><div> While documenta= tion is provided a note about this during install<br></div><div> would<br><= /div><div> <br></div><div> be helpful.<br></div><div> <br></div><div> Image= source:<br></div><div> <br></div><div> <a data-ik=3D"ik-secure" rel=3D"noo= pener noreferrer" href=3D"https://sembiance.com/fileFormatSamples/image/pcd= /" class=3D"defaultMailLink defaultMailLink" target=3D"_blank">https://semb= iance.com/fileFormatSamples/image/pcd/</a><br></div><div> <br></div><div> C= XXFLAGS are dropped due to misspelling<br></div><div> <br></div><div> <a da= ta-ik=3D"ik-secure" rel=3D"noopener noreferrer" href=3D"https://cgit.freebs= d.org/ports/tree/graphics/pcdtojpeg/Makefile?id=3D942e8b555262a6e684ef69e96= e0036e065fb8211#n23" class=3D"defaultMailLink defaultMailLink" target=3D"_b= lank">https://cgit.freebsd.org/ports/tree/graphics/pcdtojpeg/Makefile?id=3D= 942e8b555262a6e684ef69e96e0036e065fb8211#n23</a><br></div><div> <br></div><= div> We likely avoid doing exercises with tar in post-install sections?<br>= </div><div> <br></div><div> Please sort USES and make it a separate section= s.<br></div><div> <br></div><div> I'm not sure if the claims on the page ar= e still valid as<br></div><div> ImageMagick7<br></div><div> <br></div><div>= appears to work fine as long as you set colorspace to sRGB during<br></div= ><div> <br></div><div> conversion.<br></div><div> <br></div><div> Best rega= rds,<br></div><div> <br></div><div> Daniel<br></div></blockquote><div> <br>= </div><div>Hi,<br></div><div><br></div><div>Might also add that ffmpeg also= seems to convert without any issues<br></div><div>however the image is rot= ated 90 degrees.<br></div><div><br></div><div>Best regards,<br></div><div><= br></div><div>Daniel<br></div></pre></blockquote></div><div style=3D"font-f= amily:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Hi,<b= r></div><div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, sans-= serif;font-size:14px;"><br></div><div style=3D"font-family:'Helvetica Neue'= , Helvetica, Arial, sans-serif;font-size:14px;">Please respond otherwise th= is will likely be backed out as it doesn't work.<br></div><div style=3D"fon= t-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;"><b= r></div><div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, sans-= serif;font-size:14px;">Best regards,<br></div><div style=3D"font-family:'He= lvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Daniel<br></di= v></body></html> --_=_swift_1737300252_b897e47a1208bcdbeacbb27744f779ae_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?23a3b99a51170a06f24f96681b418e74>