Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Aug 2008 01:22:41 -0400
From:      Joe Marcus Clarke <marcus@marcuscom.com>
To:        Adam Weinberger <adamw@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, QA Tindy <itetcu@FreeBSD.org>, Mark Linimon <linimon@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/games/secretmaryochronicles-music Makefile
Message-ID:  <1218432161.50866.30.camel@shumai.marcuscom.com>
In-Reply-To: <20080811052212.GB14722@toxic.magnesium.net>
References:  <200808101825.m7AIPpkv047640@repoman.freebsd.org> <20080811051155.5de8cac2@it.buh.tecnik93.com> <20080811041508.GB3390@toxic.magnesium.net> <1218429383.50866.24.camel@shumai.marcuscom.com> <20080811044844.GA13771@toxic.magnesium.net> <1218430765.50866.27.camel@shumai.marcuscom.com> <20080811052212.GB14722@toxic.magnesium.net>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On Sun, 2008-08-10 at 22:22 -0700, Adam Weinberger wrote:
> >> (08.10.2008 @ 2159 PST): Joe Marcus Clarke said, in 2.4K: <<
> > On Sun, 2008-08-10 at 21:48 -0700, Adam Weinberger wrote:
> > > >> (08.10.2008 @ 2136 PST): Joe Marcus Clarke said, in 1.8K: <<
> > > > On Sun, 2008-08-10 at 21:15 -0700, Adam Weinberger wrote:
> > > > > >> (08.10.2008 @ 1911 PST): QA Tindy said, in 4.0K: <<
> > > > > > 
> > > > > > ===>   Registering installation for secretmaryochronicles-music-4.0  
> > > > > > Creating bzip'd tar ball in '/tmp/packages/All/secretmaryochronicles-music-4.0.tbz'
> > > > > > Deleting secretmaryochronicles-music-4.0
> > > > > > 
> > > > > > === Checking filesystem state
> > > > > > list of extra files and directories in / (not present before this port was installed but present after it was deinstalled)
> > > > > > 7113692        4 drwxr-xr-x    2 root             wheel                 512 Aug 10 22:55 usr/local/share/smc/music
> > > > > > ================================================================
> > > > > > build of /usr/ports/games/secretmaryochronicles-music ended at Sun Aug 10 22:55:31 UTC 2008
> > > > > > 
> > > > > >> end of "Re: cvs commit: ports/games/secretmaryochronicles-music Makefile" from QA Tindy <<
> > > > > 
> > > > > Is there something in particular that I'm missing here? That directory
> > > > > is created by a dependent port (games/secretmaryochronicles).
> > > > 
> > > > games/secretmaryochronicles is missing the following in pkg-plist:
> > > > 
> > > > @exec mkdir -p %D/share/smc/music
> > > > 
> > > > Joe
> > > >> end of "Re: cvs commit: ports/games/secretmaryochronicles-music Makefile" from Joe Marcus Clarke <<
> > > 
> > > At least on my machine, that directory is created by the install
> > > process...
> > 
> > During the PORT install process, not the PACKAGE install process.  The
> > latter is what is used when building secretmaryocrhonicles-music, and it
> > is the reason the directory isn't created before
> > secretmaryochronicles-music is installed.
> > 
> >> end of "Re: cvs commit: ports/games/secretmaryochronicles-music Makefile" from Joe Marcus Clarke <<
> 
> Seems odd that a directory created by the games/secretmaryochronicles
> port install process wouldn't be part of the package that's made of it,
> unless the package thinger doesn't pick up empty directories. But, I'll
> take your word for it. I've poked the maintainer to make the change.

It doesn't.  Empty directories must be manually created in the plist or
in a pkg-install script.  See sysutils/consolekit for a few examples.

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEABECAAYFAkifzKAACgkQb2iPiv4Uz4cB8ACfWJR96/8dW5D656oFGPjJwwSk
x1kAnA7dLwXhqVMABB/inglVIRQ4J1n0
=QAz+
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1218432161.50866.30.camel>