Date: Fri, 7 Jan 2022 11:30:31 +0100 From: marco+freebsd@crowdsec.net To: freebsd-ports@freebsd.org Subject: Re: Go dependencies and broken build Message-ID: <CAKjC73ZJ2TpQ31wTy7ZxXs0_akmTE3Zongw1bY4t3yeC5o_LxQ@mail.gmail.com> In-Reply-To: <CAKjC73Zo8Df3sA%2BdB_3pYETpZk50BisWRH=DB=8c1sVLxf=%2BTw@mail.gmail.com> References: <CAKjC73Zo8Df3sA%2BdB_3pYETpZk50BisWRH=DB=8c1sVLxf=%2BTw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000099a23205d4fb7a69 Content-Type: text/plain; charset="UTF-8" Hello! I follow up on my own email to correct the link: the bug is actually https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260262 It has now been re-assigned to nobody. Can someone take it and commit the new patches? That would allow us to have a new official version and publish the related OPNSense plugin. Thanks again, Marco On Mon, Jan 3, 2022 at 2:05 PM Marco Mariani <marco@crowdsec.net> wrote: > Hello! > > I am in charge of maintaining the ports of security/crowdsec and > security/crowdsec-firewall-bouncer, which are currently broken since a > couple of weeks for not providing all Go dependencies before build time. > I work for the upstream company but had little previous freebsd > experience, hence the bug on my first port submission. > > Now, for the short term, I have submitted a fix that builds from a git tag > with all vendored dependencies, and added the patch to > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260264 > > I understand the previous maintainer (to whom the bug is assigned) has > little time right now to review and commit again, so if somebody could > have a look it would be greatly appreciated. > > In the long term, I'd like to avoid vendoring everything, which is not > recommended by core Go devs anymore. > The version of the port I inherited made use of go:modules from Mk/Uses/ > go.mk, but our software has since grown some plugins as sub-projects with > their own dependencies. It was a lot simpler to just call our own Makefile, > as I did in > https://github.com/crowdsecurity/packaging-freebsd/blob/master/security/crowdsec/Makefile > > My approach should then be to port the technique from go.mk to our > Makefile (and run "go mod download", "go mod vendor".. by hand). > > A bit tricky (it would create one set of .zip and .mod for each plugin) > but it should be doable. What do you think? Is there a simpler way? > > Thanks, > Marco > --00000000000099a23205d4fb7a69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello!</div><div><br></div><div>I follow up on my own= email to correct the link: the bug is actually <a href=3D"https://bugs.fre= ebsd.org/bugzilla/show_bug.cgi?id=3D260262">https://bugs.freebsd.org/bugzil= la/show_bug.cgi?id=3D260262</a></div><div><br></div><div>It has now been re= -assigned to nobody. <br></div><div>Can someone take it and commit the new = patches?</div><div>That would allow us to have a new official version and p= ublish the related OPNSense plugin.<br></div><div><br></div><div>Thanks aga= in,</div><div>Marco<br></div><div><br></div><div><br></div><div><br></div><= /div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">O= n Mon, Jan 3, 2022 at 2:05 PM Marco Mariani <<a href=3D"mailto:marco@cro= wdsec.net">marco@crowdsec.net</a>> wrote:<br></div><blockquote class=3D"= gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20= 4,204,204);padding-left:1ex"><div dir=3D"ltr">Hello!<br><br><div>I am in ch= arge of maintaining the ports of security/crowdsec and security/crowdsec-fi= rewall-bouncer, which are currently broken since a couple of weeks for not = providing all Go=C2=A0 dependencies before build time.</div><div>I work for= the upstream company but had little previous freebsd experience, hence the= bug on my first port submission.<br></div><br>Now, for the short term, I h= ave submitted a fix that builds from a git tag with all vendored dependenci= es, and added the patch to <a href=3D"https://bugs.freebsd.org/bugzilla/sho= w_bug.cgi?id=3D260264" target=3D"_blank">https://bugs.freebsd.org/bugzilla/= show_bug.cgi?id=3D260264</a><br><br>I understand the previous maintainer (t= o whom the bug is assigned) has little time right now to review and commit = again,=C2=A0 so if somebody could have a look it would be greatly appreciat= ed.<br><br><div>In the long term, I'd like to avoid vendoring everythin= g, which is not recommended by core Go devs anymore.</div><div>The version = of the port I inherited made use of go:modules from Mk/Uses/<a href=3D"http= ://go.mk" target=3D"_blank">go.mk</a>, but our software has since grown som= e plugins as sub-projects with their own dependencies. It was a lot simpler= to just call our own Makefile, as I did in <a href=3D"https://github.com/c= rowdsecurity/packaging-freebsd/blob/master/security/crowdsec/Makefile" targ= et=3D"_blank">https://github.com/crowdsecurity/packaging-freebsd/blob/maste= r/security/crowdsec/Makefile</a></div><div><br></div><div>My approach shoul= d then be to port the technique from <a href=3D"http://go.mk" target=3D"_bl= ank">go.mk</a> to our Makefile (and run "go mod download", "= go mod vendor".. by hand).<br></div><br>A bit tricky (it would create = one set of .zip and .mod for each plugin) but it should be doable. What do = you think? Is there a simpler way?<br><br>Thanks,<br>Marco<br></div> </blockquote></div> --00000000000099a23205d4fb7a69--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKjC73ZJ2TpQ31wTy7ZxXs0_akmTE3Zongw1bY4t3yeC5o_LxQ>