Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Mar 2025 16:39:17 -0800
From:      Kevin Oberman <rkoberman@gmail.com>
To:        "Bjoern A. Zeeb" <bz@freebsd.org>
Cc:        FreeBSD wireless mailing list <wireless@freebsd.org>
Subject:   Re: iwlwifi / rtw88 / rtw89 hw crypto request for test (precon for HT/VHT)
Message-ID:  <CAN6yY1u6Wucp-E9TN0_rKnLxOW06zri1a1WHGPRrsihxZ28f-g@mail.gmail.com>
In-Reply-To: <o5965196-r5op-no6o-16ps-s094r7483p70@SerrOFQ.bet>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Mon, Feb 17, 2025 at 8:01 PM Bjoern A. Zeeb <bz@freebsd.org> wrote:

> Hi,
>
> with [1] I added HW_CRYPTO support to the build for all LinuxKPI based
> drivers.  This is a pre-condition to make HT/VHT work with drivers/fw
> which support, e.g., A-MPDU offloading -- basically almost everything
> modern.
>
> I will very likely MFC it at the end of the week if I didn't put in any
> last minute bugs.
>
> As the commit message says it currently only supports CCMP.  If you
> still do WEP or TKIP please let me know and I'll add it to the list
> though I'll then likely want your help to test (patches) as well.
>
> As also mentioned in the commit message I saw one specific panic in the
> past which I no longer can reproduce.  I am sure there's some other edge
> cases on more devices so I need your help to test.
>
> While the code is compiled in now it is disabled behind a tunable until
> there is sufficient feedback for iwlwifi, rtw88 and rtw89 that it works.
> Once that happens I'll flip the default for the tunable at least to on
> and eventually remove it alltogether and we can move to the next steps
> of testing which is hopefully fully merged to git by then.
>
> So if you want some HT/VHT to work with at least modern iwlwifi, and then
> also older iwlwifi, rtw88 and rtw89 in th enext steps please help testing
> and report back the next days.
>
> To turn the code on add the following line to laoder.conf:
>         compat.linuxkpi.80211.hw_crypto=1
>
> At runtime you can check the state by using:
>         sysctl compat.linuxkpi.80211.hw_crypto
>
> Also if you have any problems, then you can easily remove that line (or
> unset it from loader) and boot with the support turned on.
>
> If you reply to this thread or me (positive or negative feedback), please
> add the pciconf -l line for your wifi card so we known about the chipset.
>
>
> Lots of joy,
> Bjoern
>
> [1]
> https://cgit.FreeBSD.org/src/commit/?id=11db70b6057e41b259dc2245cd893d5b19179fcc
>
> --
> Bjoern A. Zeeb                                                     r15:7
>
> I was excited to see that it looked like 802.11n was on the way! Tried
step one, enabling 802.11 crypto, and had no luck at all. I know my AX211
supports CCMP, but attempting to boot gets:
wlan0: link state changed to UP
iwlwifi0: _lkpi_iv_key_set: CIPHER SUITE 0xfac02 (TKIP) not supported
wlan0: link state changed to DOWN

Why don't I see any attempt to do CCMP? Am I looking at an issue with the
Arris WiFi provided by my carrier (Frontier)? I can't find any reference to
encryption in the DHCP configuration. Mine is very basic PSK:
network={
  ssid="My BSS"
  psk="My key"
  priority=5
}


After several tries at getting an address, it gives up and the system
crashed. I have the text dump and will attach the crash message. Also have
the full dmesg, if they are of use. I probably am simply missing something.

Thanks!

I enabled it is loader.conf, but the reboot failed to connect and then
crashed.


-- 
Kevin Oberman, Part time kid herder and retired Network Engineer
E-mail: rkoberman@gmail.com
PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683

[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">On Mon, Feb 17, 2025 at 8:01 PM Bjoern A. Zeeb &lt;<a href="mailto:bz@freebsd.org">bz@freebsd.org</a>&gt; wrote:</div></div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
with [1] I added HW_CRYPTO support to the build for all LinuxKPI based<br>
drivers.  This is a pre-condition to make HT/VHT work with drivers/fw<br>
which support, e.g., A-MPDU offloading -- basically almost everything<br>
modern.<br>
<br>
I will very likely MFC it at the end of the week if I didn&#39;t put in any<br>
last minute bugs.<br>
<br>
As the commit message says it currently only supports CCMP.  If you<br>
still do WEP or TKIP please let me know and I&#39;ll add it to the list<br>
though I&#39;ll then likely want your help to test (patches) as well.<br>
<br>
As also mentioned in the commit message I saw one specific panic in the<br>
past which I no longer can reproduce.  I am sure there&#39;s some other edge<br>
cases on more devices so I need your help to test.<br>
<br>
While the code is compiled in now it is disabled behind a tunable until<br>
there is sufficient feedback for iwlwifi, rtw88 and rtw89 that it works.<br>
Once that happens I&#39;ll flip the default for the tunable at least to on<br>
and eventually remove it alltogether and we can move to the next steps<br>
of testing which is hopefully fully merged to git by then.<br>
<br>
So if you want some HT/VHT to work with at least modern iwlwifi, and then<br>
also older iwlwifi, rtw88 and rtw89 in th enext steps please help testing<br>
and report back the next days.<br>
<br>
To turn the code on add the following line to laoder.conf:<br>
        compat.linuxkpi.80211.hw_crypto=1<br>
<br>
At runtime you can check the state by using:<br>
        sysctl compat.linuxkpi.80211.hw_crypto<br>
<br>
Also if you have any problems, then you can easily remove that line (or<br>
unset it from loader) and boot with the support turned on.<br>
<br>
If you reply to this thread or me (positive or negative feedback), please<br>
add the pciconf -l line for your wifi card so we known about the chipset.<br>
<br>
<br>
Lots of joy,<br>
Bjoern<br>
<br>
[1] <a href="https://cgit.FreeBSD.org/src/commit/?id=11db70b6057e41b259dc2245cd893d5b19179fcc" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=11db70b6057e41b259dc2245cd893d5b19179fcc</a><br>;
<br>
-- <br>
Bjoern A. Zeeb                                                     r15:7<br>
<br>
</blockquote></div><div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">I was excited to see that it looked like 802.11n was on the way! Tried step one, enabling 802.11 crypto, and had no luck at all. I know my AX211 supports CCMP, but attempting to boot gets:</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">wlan0: link state changed to UP<br>iwlwifi0: _lkpi_iv_key_set: CIPHER SUITE 0xfac02 (TKIP) not supported<br>wlan0: link state changed to DOWN</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">Why don&#39;t I see any attempt to do CCMP? Am I looking at an issue with the Arris WiFi provided by my carrier (Frontier)? I can&#39;t find any reference to encryption in the DHCP configuration. Mine is very basic PSK:</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">network={<br>  ssid=&quot;My BSS&quot;<br>  psk=&quot;My key&quot;<br>  priority=5<br>}<br><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">After several tries at getting an address, it gives up and the system crashed. I have the text dump and will attach the crash message. Also have the full dmesg, if they are of use. I probably am simply missing something.</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">Thanks!</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">I enabled it is loader.conf, but the reboot failed to connect and then crashed.</div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Kevin Oberman, Part time kid herder and retired Network Engineer<br>E-mail: <a href="mailto:rkoberman@gmail.com" target="_blank">rkoberman@gmail.com</a><br></div><div>PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683</div></div></div></div></div></div></div></div></div>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAN6yY1u6Wucp-E9TN0_rKnLxOW06zri1a1WHGPRrsihxZ28f-g>