Date: Tue, 24 Sep 2002 22:05:29 +1000 From: Stephen McKay <smckay@internode.on.net> To: Mikhail Teterin <mi+mx@aldan.algebra.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Stephen McKay <smckay@internode.on.net> Subject: Re: cvs commit: src/bin/cp cp.c Message-ID: <200209241205.g8OC5T810606@dungeon.home> In-Reply-To: <200209231428.06798.mi%2Bmx@aldan.algebra.com> from Mikhail Teterin at "Mon, 23 Sep 2002 14:28:06 -0400" References: <200209221115.g8MBFv00023063@freefall.freebsd.org> <200209231428.06798.mi%2Bmx@aldan.algebra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, 23rd September 2002, Mikhail Teterin wrote: >On Sunday 22 September 2002 07:15 am, Stephen McKay wrote: >> mckay 2002/09/22 04:15:57 PDT >> >> Modified files: >> bin/cp cp.c >> Log: >> cp -p could report success even if a file copy failed. This was >> due to the cumulative exit status being overwritten when directory >> permissions were being set. This was particularly bad when called >> from mv(1) to perform a cross-device move as the original files were >> deleted even if the copy failed. > >It could also report failure -- from changing the timestamps and such, >even though the file was copied. It, probably, still should report the >problem, but the message the user sees should be more detailed. Failure in utimes() is still a failure. Errors show which system call failed and I think that's enough. But if you submit a PR with a patch to improve error messages I'm sure it will be considered. >What about MFC-ing? Just received RE approval. Stephen. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209241205.g8OC5T810606>