Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Sep 2022 15:34:45 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Emmanuel Vadot <manu@bidouilliste.com>
Cc:        Mitchell Horne <mhorne@freebsd.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>, John Baldwin <jhb@freebsd.org>
Subject:   Re: git: 10c6af344108 - main - bhyve: Fix build when BHYVE_SNAPSHOT is set
Message-ID:  <526E3D8E-895C-476E-BB7C-F2EE61DA456E@freebsd.org>
In-Reply-To: <20220913163250.199f7ae9cf021249846a9133@bidouilliste.com>
References:  <202209130632.28D6WdW9021176@gitrepo.freebsd.org> <9903ef54-80a9-67e6-f9ab-1371c42916ff@freebsd.org> <20220913163250.199f7ae9cf021249846a9133@bidouilliste.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 13 Sept 2022, at 15:32, Emmanuel Vadot <manu@bidouilliste.com> wrote:
>=20
> On Tue, 13 Sep 2022 10:49:46 -0300
> Mitchell Horne <mhorne@freebsd.org> wrote:
>=20
>>=20
>>=20
>> On 9/13/22 03:32, Emmanuel Vadot wrote:
>>> The branch main has been updated by manu:
>>>=20
>>> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D10c6af344108a8cfdc431b5b304de9c0=
fddcec47
>>>=20
>>> commit 10c6af344108a8cfdc431b5b304de9c0fddcec47
>>> Author: Filipe da Silva Santos <contact@mail.shiori.com.br>
>>> AuthorDate: 2022-09-13 06:30:41 +0000
>>> Commit: Emmanuel Vadot <manu@FreeBSD.org>
>>> CommitDate: 2022-09-13 06:32:09 +0000
>>>=20
>>> bhyve: Fix build when BHYVE_SNAPSHOT is set
>>>=20
>>=20
>> Can this option be added to LINT?
>>=20
>> Mitchell
>=20
> Probably should as it would have prevent this, but I'm not sure of why
> this is an option currently, John ?

It disables capsicum support as the two aren=E2=80=99t currently =
compatible.

Also, LINT wouldn=E2=80=99t help, this is userspace not the kernel.

Jess

>>=20
>>> Fixes: 9cc9abf409cc ("bhyve: create all vcpus on startup")
>>> Sponsored by: Beckhoff Automation GmbH & Co. KG
>>> X-MFC-With: 9cc9abf409cc
>>> ---
>>> usr.sbin/bhyve/bhyverun.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>=20
>>> diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c
>>> index 550cc9d15477..27f1d8ea8892 100644
>>> --- a/usr.sbin/bhyve/bhyverun.c
>>> +++ b/usr.sbin/bhyve/bhyverun.c
>>> @@ -1244,7 +1244,6 @@ main(int argc, char *argv[])
>>> #ifdef BHYVE_SNAPSHOT
>>> 	char *restore_file;
>>> 	struct restore_state rstate;
>>> -	int vcpu;
>>>=20
>>> 	restore_file =3D NULL;
>>> #endif
>=20
>=20
> --=20
> Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?526E3D8E-895C-476E-BB7C-F2EE61DA456E>