Date: Wed, 27 Nov 2024 17:25:10 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Kristof Provost <kp@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 45d108ee147c - main - pf_route6(): one more __sdt_used annotation Message-ID: <Z0c51p6MUxrKKaKg@kib.kiev.ua> In-Reply-To: <5F91DA38-12C0-412C-9430-7632A0BBB763@FreeBSD.org> References: <202411271431.4AREVRbs047403@gitrepo.freebsd.org> <5F91DA38-12C0-412C-9430-7632A0BBB763@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 27, 2024 at 04:10:21PM +0100, Kristof Provost wrote: > On 27 Nov 2024, at 15:31, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=45d108ee147cc8776a659578da585b31a0ba5643 > > > > commit 45d108ee147cc8776a659578da585b31a0ba5643 > > Author: Konstantin Belousov <kib@FreeBSD.org> > > AuthorDate: 2024-11-27 14:26:53 +0000 > > Commit: Konstantin Belousov <kib@FreeBSD.org> > > CommitDate: 2024-11-27 14:30:52 +0000 > > > > pf_route6(): one more __sdt_used annotation > > Thanks! > > I thought I’d fixed that when you reported the initial problem, but clearly I missed one. > > I wonder if we shouldn’t remove options KDTRACE_HOOKS from at least one kernel config to improve the odds of catching mistakes like this one pre-commit. > >From MINIMAL maybe? Perhaps it should be removed from LINT. Initial idea around it was that LINT should complement options in other kernels configs, I believe.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Z0c51p6MUxrKKaKg>