Date: Wed, 14 Aug 2013 13:17:05 -0400 From: Richard Yao <ryao@gentoo.org> To: Steven Hartland <killing@multiplay.co.uk> Cc: hackers@FreeBSD.org, Eitan Adler <eadler@FreeBSD.org> Subject: Re: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2 Message-ID: <520BBB91.4010209@gentoo.org> In-Reply-To: <E1D03880075F415983CA900DAE47304C@multiplay.co.uk> References: <1376223145-81081-1-git-send-email-ryao@gentoo.org> <E1D03880075F415983CA900DAE47304C@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2JGBTUTDXAIXHUGNSGMVV
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
I neglected to include the CC list on the previous email that I sent, so
here is a reproduction:
I am afraid that is not possible. I extracted the "MARVELL SD88SA02"
entry from Open Solaris. The OCZ Agility 2 entry was provided by another
Gentoo developer using a tool that performed an inquiry query and
extracted the exact 24 bytes in the combined vendor/product
identification fields. The same was done for the X25-M. I actually do
own one of those and could get FreeBSD running on that machine, but
Artem Belevich has already responded with that information.
On 08/13/2013 10:02 PM, Steven Hartland wrote:
> Could you provide the output from camcontrol identify for these
> disks I want to just double check the formatting before commiting as I
> don't have these disks here in labs.
>=20
> Regards
> Steve
>=20
> ----- Original Message ----- From: "Richard Yao" <ryao@gentoo.org>
> To: <hackers@FreeBSD.org>
> Cc: "Richard Yao" <ryao@gentoo.org>; "Eitan Adler" <eadler@FreeBSD.org>=
> Sent: Sunday, August 11, 2013 1:12 PM
> Subject: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ=
> Agility 2
>=20
>=20
>> Signed-off-by: Richard Yao <ryao@gentoo.org>
>> ---
>> sys/cam/ata/ata_da.c | 24 ++++++++++++++++++++++++
>> sys/cam/scsi/scsi_da.c | 24 ++++++++++++++++++++++++
>> 2 files changed, 48 insertions(+)
>>
>> diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c
>> index f201231..b7f293d 100644
>> --- a/sys/cam/ata/ata_da.c
>> +++ b/sys/cam/ata/ata_da.c
>> @@ -349,6 +349,14 @@ static struct ada_quirk_entry ada_quirk_table[] =3D=
>> },
>> {
>> /*
>> + * Intel X25-M Series SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> * Kingston E100 Series SSDs
>> * 4k optimised & trim only works in 4k requests + 4k aligned
>> */
>> @@ -365,6 +373,22 @@ static struct ada_quirk_entry ada_quirk_table[] =3D=
>> },
>> {
>> /*
>> + * Marvell SSD (entry taken from Open Solaris)
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> + * OCZ Agility 2 SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> * OCZ Agility 3 SSDs
>> * 4k optimised & trim only works in 4k requests + 4k aligned
>> */
>> diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
>> index 617afbd..df895be 100644
>> --- a/sys/cam/scsi/scsi_da.c
>> +++ b/sys/cam/scsi/scsi_da.c
>> @@ -1008,6 +1008,14 @@ static struct da_quirk_entry da_quirk_table[] =3D=
>> },
>> {
>> /*
>> + * Intel X25-M Series SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> * Kingston E100 Series SSDs
>> * 4k optimised & trim only works in 4k requests + 4k aligned
>> */
>> @@ -1024,6 +1032,22 @@ static struct da_quirk_entry da_quirk_table[] =3D=
>> },
>> {
>> /*
>> + * Marvell SSD (entry taken from Open Solaris)
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> + * OCZ Agility 2 SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> * OCZ Agility 3 SSDs
>> * 4k optimised & trim only works in 4k requests + 4k aligned
>> */
>> --=20
>> 1.8.1.5
>>
>> _______________________________________________
>> freebsd-hackers@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
>> To unsubscribe, send any mail to
>> "freebsd-hackers-unsubscribe@freebsd.org"
>>
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> This e.mail is private and confidential between Multiplay (UK) Ltd. and=
> the person or entity to whom it is addressed. In the event of
> misdirection, the recipient is prohibited from using, copying, printing=
> or otherwise disseminating it or any information contained in it.
> In the event of misdirection, illegible or incomplete transmission
> please telephone +44 845 868 1337
> or return the E.mail to postmaster@multiplay.co.uk.
>=20
------enig2JGBTUTDXAIXHUGNSGMVV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSC7uUAAoJECDuEZm+6Exk8E8P/R8NdfZmkONsOO7xIaryrWGT
P3KHdHFS5iTZvqfEjnSkvpH/8irlBY2L6ld9MifP/yZyKZxb+yIDNCIsettZG8Bu
pgpVebGeNmumzQAR/NY3NNyZxnYBjP2nhZaVJVIAu0I/WRrtgCIiHfGQruQ9Olp+
UxBU3qdaZG//FpFq9uWugjVG/iag2R6HgZfHnPqygRHB6yqj83xVSxVT8K32KkIe
vGus6wFr0H54qWIfNnbYQlKrSVKd8OPo+/XyOByKWgCys+609IyX/xiVWjHR2/ey
4/Ax11EpRBGv+tMp8yVmL0OL+pBlPS2MtCCkkaHd6Va63TtwNxW5RJIygD8gD5cO
FOmHgXL4diX6NXU9xqBe5+yido8WPQ5cMz9dQPNVpdswfjnv3DLa+orSItaplAbi
TZxN2C9h7TO/r9u8FVZwt7+MQqhP7JUZj0oG4/g+xrQoORTdGikmZroQ8zaETeaC
Lr3YN4y8dpf4tLsPBG5PBVVvr0TVharxEBJ0edlzyGqpTZprJUT+9YDvsxKdVuDU
NsaKrChHyC1iKC1SYjhm1GSwcKzTdE4ZhEnRlPSLFM3wN0Zs/Gb8awyO6Hq3huNr
fqFoFiTmNug7oSkZGV/8kJWmbFYqAXtHYNFC168EhfMq7rVKGRZ/UiELb2QxWWO/
bWVa2DPNQQJ2/V9W7wf4
=gWSA
-----END PGP SIGNATURE-----
------enig2JGBTUTDXAIXHUGNSGMVV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?520BBB91.4010209>