Date: Sun, 30 Jun 2013 15:23:31 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, "dt71@gmx.com" <dt71@gmx.com>, svn-src-all@freebsd.org, Tim Kientzle <kientzle@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r252376 - head/lib/libutil Message-ID: <65B29369-2B3C-4018-AFEA-AC57E86404A3@FreeBSD.org> In-Reply-To: <20130629161914.GD91021@kib.kiev.ua> References: <201306291552.r5TFqnLV022460@svn.freebsd.org> <20130629161914.GD91021@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 29, 2013, at 18:19, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Sat, Jun 29, 2013 at 03:52:49PM +0000, Tim Kientzle wrote: >> Author: kientzle >> Date: Sat Jun 29 15:52:48 2013 >> New Revision: 252376 >> URL: http://svnweb.freebsd.org/changeset/base/252376 >> >> Log: >> Fix -Wunsequenced warning > What is this ? From the name of the warning, it sounds as if the problem > is in the lack of sequence point between two modifications of the same > variable in the expression ? > > But, there function' argument evaluation and function call are separated > by seq point, AFAIR. Could you, please, clarify ? Yes, a function call is a sequence point. The -Wunsequenced warning was made too aggressive in this trunk upstream commit: <http://llvm.org/viewvc/llvm-project?rev=185035&view=rev>; I pointed out the problem to the author, and he fixed it in: <http://llvm.org/viewvc/llvm-project?rev=185282&view=rev>; -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?65B29369-2B3C-4018-AFEA-AC57E86404A3>