Date: Tue, 19 Mar 2019 17:12:15 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Eric Joyner <erj@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345312 - in head: share/man/man9 sys/net sys/sys Message-ID: <b0192344-95f9-5705-2faa-69f6a90b50c6@FreeBSD.org> In-Reply-To: <201903192344.x2JNiQrn055852@repo.freebsd.org> References: <201903192344.x2JNiQrn055852@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/19/19 4:44 PM, Eric Joyner wrote: > Author: erj > Date: Tue Mar 19 23:44:26 2019 > New Revision: 345312 > URL: https://svnweb.freebsd.org/changeset/base/345312 > > Log: > iflib: mark isc_driver_version as constant > > From Jake: > The iflib core never modifies the isc_driver_version string. Allow > drivers to safely assign pointers to constant buffers by marking this > parameter const. I didn't say it in the review, but FWIW, I probably would have added SYSCTL_CONST_STRING as its own commit first (so it can be MFC'd standalone, etc.) with its own message and then committed the iflib change that uses it second. Just something to consider for the future. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b0192344-95f9-5705-2faa-69f6a90b50c6>