Date: Tue, 19 Aug 2003 12:11:57 -0500 From: Dan Nelson <dnelson@allantgroup.com> To: Andre Guibert de Bruet <andy@siliconlandmark.com> Cc: current@freebsd.org Subject: Re: fwcontrol -r missing a close() call Message-ID: <20030819171155.GC5141@dan.emsphone.com> In-Reply-To: <20030819110750.Q452@alpha.siliconlandmark.com> References: <20030819110750.Q452@alpha.siliconlandmark.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In the last episode (Aug 19), Andre Guibert de Bruet said:
> open("/dev/fw0.0",0x2,01001132500) = 3 (0x3)
> ioctl(3,FW_IBUSRST,0xbfbff400) = 0 (0x0)
> exit(0x0)
> process exit, rval = 0
>
> We're not closing fd #3 before exiting the process. This is also the case
> with 4.8-STABLE.
>
> Semantics? Nit-picking? Both? :)
Why bother closing a fd when exit() will do it for you? You don't
close stdout when you're done with it :)
--
Dan Nelson
dnelson@allantgroup.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030819171155.GC5141>