Date: Fri, 21 Jun 2024 23:41:49 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Thierry Thomas <thierry@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 12594e1aee7b - main - math/mathex: new port, C++ library to parse/evaluate mathematical expressions Message-ID: <805b3975a564733fe080a864a330c1d7@mail.infomaniak.com> In-Reply-To: <ZnXdFYKXnHGS8wOE@graf.pompo.net> References: <202406211115.45LBFt3m025401@gitrepo.freebsd.org> <74dfc79ede606f9424af2b0f564b01f3@mail.infomaniak.com> <ZnVvwBGocIxc0K14@graf.pompo.net> <224470ebe4c1f9da0c394a33cfde261e@mail.infomaniak.com> <ZnXdFYKXnHGS8wOE@graf.pompo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1719006109_11f902dcc062f2b42de0fd33fb8a7349_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-06-21T22:05:41.000+02:00, Thierry Thomas <thierry@freebsd.org> wr= ote: >=C2=A0Le=C2=A0ven.=C2=A021=C2=A0juin=C2=A024=C2=A0=C3=A0=C2= =A015:42:24=C2=A0+0200,=C2=A0Daniel=C2=A0Engberg=C2=A0<daniel.engberg.lists= @pyret.net> >=C2=A0 >=C2=A0=C2=A0=C3=A9crivait=C2=A0: >=C2=A0 >>= =C2=A0=C2=A0The=C2=A0only=C2=A0consumer=C2=A0(not=C2=A0linked?)=C2=A0uses= =C2=A0CMake=C2=A0too=C2=A0so=C2=A0I=C2=A0don't=C2=A0see >>=C2=A0=C2=A0tha= t >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0much=C2=A0of=C2=A0a=C2=A0concern?= >=C2=A0 >=C2=A0Maybe,=C2=A0but=C2=A0I=C2=A0prefer=C2=A0the=C2=A0classi= cal=C2=A0way. >=C2=A0 >>=C2=A0=C2=A0Here's=C2=A0a=C2=A0poc=C2=A0with= =C2=A0prefix(ed)=C2=A0examples,matching=C2=A0comment=C2=A0(there=C2=A0a >= >=C2=A0=C2=A0typo) >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0and=C2=A0pkg-desc= r=C2=A0(slightly=C2=A0altered). >=C2=A0 >=C2=A0Thanks,=C2=A0I=E2=80= =99ve=C2=A0just=C2=A0fixed=C2=A0them! There's still a typo in COMMENT,= "C++ library fo" >>=C2=A0=C2=A0Plist=C2=A0is=C2=A0also=C2=A0fixed= =C2=A0when=C2=A0EXAMPLES=C2=A0are=C2=A0disabled=C2=A0(needs=C2=A0to=C2= =A0be >>=C2=A0=C2=A0patched >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0either= =C2=A0way). >=C2=A0 >=C2=A0Do=C2=A0you=C2=A0build=C2=A0it=C2=A0with= =C2=A0some=C2=A0unclean=C2=A0environment? It fails using both ports (1= 4.0, amd64) and Poudriere ... math_mathex_UNSET=3D=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 EXAMPLES ... --> https://pdr2.bofh.network/d= ata/132-diizzy/mathex-no-examples/logs/errors/mathex-0.3.b.log Conside= r using the OPTIONS_SUB helper which makes it much easier https://docs= .freebsd.org/en/books/porters-handbook/book/#options_sub Please also a= t least prefix the binaries (examples) as they have with very generic nam= es both in terms of figuring out what package they belong to and would cl= ash if more ports would use the same approach (see security/mbedtls for e= xample) >=C2=A0Regards. >=C2=A0 >=C2=A0--=C2=A0 >=C2=A0 >= =C2=A0Th.=C2=A0Thomas. Best regards, Daniel --_=_swift_1719006109_11f902dcc062f2b42de0fd33fb8a7349_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div>On 2024-06-21T22:05:41.000+02:00, Thierry Thomas <thier= ry@freebsd.org> wrote:<br></div><div class=3D"ik_mail_quote answerConten= tMessage"><blockquote class=3D"ws-ng-quote"><pre style=3D"white-space: norm= al;"><div>Le ven. 21 juin 24 =C3=A0 15:42:24 +0200, Daniel Engberg <<a h= ref=3D"mailto:daniel.engberg.lists@pyret.net" class=3D"defaultMailLink">dan= iel.engberg.lists@pyret.net</a>><br></div><div> =C3=A9crivait :<br>= </div><div><br></div><blockquote class=3D"ws-ng-quote"><div> The only cons= umer (not linked?) uses CMake too so I don't see that<br></div><div> much o= f a concern? <br></div></blockquote><div> <br></div><div>Maybe, but I prefe= r the classical way.<br></div><div><br></div><blockquote class=3D"ws-ng-quo= te"><div> Here's a poc with prefix(ed) examples,matching comment (there a = typo)<br></div><div> and pkg-descr (slightly altered).<br></div></blockquot= e><div> <br></div><div>Thanks, I=E2=80=99ve just fixed them!<br></div></pre= ></blockquote></div><div>There's still a typo in COMMENT, "C++ library fo"<= br></div><div><br></div><div class=3D"ik_mail_quote answerContentMessage"><= blockquote class=3D"ws-ng-quote"><pre style=3D"white-space: normal;"><div><= br></div><blockquote class=3D"ws-ng-quote"><div> Plist is also fixed when = EXAMPLES are disabled (needs to be patched<br></div><div> either way).<br><= /div></blockquote><div> <br></div><div>Do you build it with some unclean en= vironment?<br></div></pre></blockquote></div><div>It fails using both ports= (14.0, amd64) and Poudriere<br></div><div>...<br></div><div>math_mathex_UN= SET=3D EXAMPLES<br></div><div>...<br></div><d= iv>--> <a href=3D"https://pdr2.bofh.network/data/132-diizzy/mathex-no-ex= amples/logs/errors/mathex-0.3.b.log">https://pdr2.bofh.network/data/132-dii= zzy/mathex-no-examples/logs/errors/mathex-0.3.b.log</a><br></div><div>Consi= der using the OPTIONS_SUB helper which makes it much easier<br></div><div><= a href=3D"https://docs.freebsd.org/en/books/porters-handbook/book/#options_= sub">https://docs.freebsd.org/en/books/porters-handbook/book/#options_sub</= a><br></div><div><br></div><div>Please also at least prefix the binaries (e= xamples) as they have with very generic names both in terms of figuring out= what package they belong to and would clash if more ports would use the sa= me approach (see security/mbedtls for example)<br></div><div class=3D"ik_ma= il_quote answerContentMessage"><blockquote class=3D"ws-ng-quote"><pre style= =3D"white-space: normal;"><div><br></div><div><br></div><div>Regards.<br></= div><div>-- <br></div><div>Th. Thomas.<br></div></pre></blockquote></div><d= iv>Best regards,<br></div><div>Daniel<br></div></body></html> --_=_swift_1719006109_11f902dcc062f2b42de0fd33fb8a7349_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?805b3975a564733fe080a864a330c1d7>