Date: Wed, 21 Feb 2001 11:44:16 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Peter Pentchev <roam@orbitel.bg> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Ben Smithurst <ben@FreeBSD.org> Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <XFMail.010221114416.jhb@FreeBSD.org> In-Reply-To: <20010221141342.A98551@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21-Feb-01 Peter Pentchev wrote:
> On Wed, Feb 21, 2001 at 04:10:19AM -0800, Ben Smithurst wrote:
>> ben 2001/02/21 04:10:19 PST
>>
>> Modified files:
>> share/man/man9 style.9
>> Log:
>> Don't suggest
>>
>> if (error = function(a1, a2))
>>
>> since it causes a warning with -Wall. Change it so it has an explicit
>> test
>> against zero,
>>
>> if ((error = function(a1, a2)) != 0)
>
> I've sometimes seen tests like:
>
> if (error = function(a1, a2), error != 0)
>
> Is this not a bit clearer?
Eek!! No, IMHO. If you want them to be separate, then do this:
error = function(a1, a2);
if (error != 0)
Say what you mean. Using the , operator usually just serves to obfuscate
things.
--
John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010221114416.jhb>