Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Jul 2019 19:36:18 +0000 (UTC)
From:      Cy Schubert <cy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r349917 - head/sys/contrib/ipfilter/netinet
Message-ID:  <201907111936.x6BJaIPU018133@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cy
Date: Thu Jul 11 19:36:18 2019
New Revision: 349917
URL: https://svnweb.freebsd.org/changeset/base/349917

Log:
  Remove a tautological test for adding a rule in the block that
  adds rules.
  
  MFC after:	1 week

Modified:
  head/sys/contrib/ipfilter/netinet/fil.c

Modified: head/sys/contrib/ipfilter/netinet/fil.c
==============================================================================
--- head/sys/contrib/ipfilter/netinet/fil.c	Thu Jul 11 19:36:14 2019	(r349916)
+++ head/sys/contrib/ipfilter/netinet/fil.c	Thu Jul 11 19:36:18 2019	(r349917)
@@ -5110,8 +5110,7 @@ frrequest(softc, unit, req, data, set, makecopy)
 		if (fp->fr_next != NULL)
 			fp->fr_next->fr_pnext = &fp->fr_next;
 		*ftail = fp;
-		if (addrem == OP_ADD)
-			ipf_fixskip(ftail, fp, 1);
+		ipf_fixskip(ftail, fp, 1);
 
 		fp->fr_icmpgrp = NULL;
 		if (fp->fr_icmphead != -1) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201907111936.x6BJaIPU018133>