Date: Mon, 06 Oct 2003 20:24:32 -0400 From: "Brian F. Feldman" <green@freebsd.org> To: Hiroki Sato <hrs@eos.ocn.ne.jp> Cc: audit@freebsd.org Subject: Re: bin/56502 Message-ID: <200310070024.h970OWPI011885@green.bikeshed.org> In-Reply-To: Message from Hiroki Sato <hrs@eos.ocn.ne.jp> <20030920.115238.96090140.hrs@eos.ocn.ne.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
I don't see any errors; there is a part that seems unnecessary, and a couple
places that have/don't have spaces where they would be preferred (so these
are just style issues anyway, not very important):
- state[-1] = MAX_TYPES * (rptr - state) + rand_type;
+ state[-1] = MAX_TYPES * (uint32_t)(rptr - state) + rand_type;
I believe that you don't need to cast in that situation, that you will get a
compatible size_t or something close to that.
--
Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\
<> green@FreeBSD.org \ The Power to Serve! \
Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310070024.h970OWPI011885>