Date: Thu, 26 Feb 2026 10:40:15 +0100 From: Wolfram Schneider <wosch@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8a9508563542 - main - tests/kern: make ssl_sendfile:truncate and ssl_sendfile:grow less flaky Message-ID: <CAMWY7CCWTRxBN5swJxYxaf8jHn_3t2Ngp1fPw7NFxFJ47-DnBA@mail.gmail.com> In-Reply-To: <69792b5c.37509.d3cf068@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Tue, 27 Jan 2026 at 22:18, Gleb Smirnoff <glebius@freebsd.org> wrote: > > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=8a9508563542d709b1a42a065e6e99e004a8b3fe > > commit 8a9508563542d709b1a42a065e6e99e004a8b3fe > Author: Gleb Smirnoff <glebius@FreeBSD.org> > AuthorDate: 2026-01-27 21:13:11 +0000 > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > CommitDate: 2026-01-27 21:17:08 +0000 > > tests/kern: make ssl_sendfile:truncate and ssl_sendfile:grow less flaky > > First problem is a trivial race that the client thread doesn't see updated > c.sbytes. Second problem applies only to the truncate test. On a machine > with huge default buffer sizes, there is a chance that sendfile(2) will > fill both buffers with amount of data that is larger than the size we plan > to truncate. To minimise chances for this scenario, increase file size > and truncate it less aggressively, also try to decrease buffer sizes. > --- > tests/sys/kern/ssl_sendfile.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) This test fails if I run `make buildworld' with MK_OPENSSL=no IMHO this test needs to be disabled in tests/sys/kern/Makefile for MK_OPENSSL=no -Wolfram --- ssl_sendfile --- /home/wosch/projects/freebsd-src/tests/sys/kern/ssl_sendfile.c:38:10: fatal error: 'openssl/ssl.h' file not found 38 | #include <openssl/ssl.h> | ^~~~~~~~~~~~~~~ 1 error generated. *** [ssl_sendfile.pieo] Error code 1 make[6]: stopped making "all" in /home/wosch/projects/freebsd-src/tests/sys/kern make[6]: 1 error -- Wolfram Schneider <wosch@FreeBSD.org> https://wolfram.schneider.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMWY7CCWTRxBN5swJxYxaf8jHn_3t2Ngp1fPw7NFxFJ47-DnBA>