Date: Sun, 10 Apr 2005 02:31:24 +0000 (UTC) From: David Schultz <das@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_sig.c Message-ID: <200504100231.j3A2VO4r000471@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
das 2005-04-10 02:31:24 UTC
FreeBSD src repository
Modified files:
sys/kern kern_sig.c
Log:
Suspend all other threads in the process while generating a core dump.
The main reason for doing this is that the ELF dump handler expects
the thread list to be fixed while the dump header is generated, so an
upcall that occurs at the wrong time can lead to buffer overruns and
other Bad Things.
Another solution would be to grab sched_lock in the ELF dump handler,
but we might as well single-thread, since the process is about to die.
Furthermore, I think this should ensure that the register sets in the
core file are sequentially consistent.
Revision Changes Path
1.304 +11 -1 src/sys/kern/kern_sig.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504100231.j3A2VO4r000471>