Date: Sun, 5 Jun 2011 21:25:09 -0400 From: Jason Hellenthal <jhell@DataIX.net> To: Scot Hetzel <swhetzel@gmail.com> Cc: jharris@widomaker.com, Robert Huff <roberthuff@rcn.com>, freebsd-ports@freebsd.org Subject: Re: Fping with WITH_IPV6=YES Message-ID: <20110606012509.GA14126@DataIX.net> In-Reply-To: <BANLkTimB5V=jDUOxXbLoiuA2UsnP6TnZNA@mail.gmail.com> References: <BANLkTi=y0j-rQUEnsn0eRnE-OHRy=H7VWg@mail.gmail.com> <20110603161358.GB1247@procyon.xvoid.org> <BANLkTikfPK0zs_8%2BV34vOfz13H9bdbVeGg@mail.gmail.com> <19946.7125.169246.84228@jerusalem.litteratus.org> <60F86515-B592-4B98-BE53-904206B6B183@lists.zabbadoz.net> <19946.11846.502201.644665@jerusalem.litteratus.org> <20110605012320.GA46823@DataIX.net> <20110605022434.GB46823@DataIX.net> <BANLkTimB5V=jDUOxXbLoiuA2UsnP6TnZNA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Kj7319i9nmIyA2yE Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Scot, On Sun, Jun 05, 2011 at 09:25:46AM -0500, Scot Hetzel wrote: > On Sat, Jun 4, 2011 at 9:24 PM, Jason Hellenthal <jhell@dataix.net> wrote: > > > > And if I might suggest, remove the old ifdef and replace with ... > > > > pre-extract: > > .if defined(WITH_IPV6) > > .undef WITH_IPV6 > > =A0@${ECHO_MSG} "******************************************************= ***************" > > =A0@${ECHO_MSG} "*** IPV6 IS NOT ENABLED FOR net/fping, IT DOES NOT WOR= K WITH IPV4 ***" > > =A0@${ECHO_MSG} "*** =A0 =A0 =A0 =A0 =A0 =A0 PLEASE SEE/USE net/fping+i= pv6 INSTEAD =A0 =A0 =A0 =A0 =A0 =A0 ***" > > =A0@${ECHO_MSG} "*** =A0 =A0THESE PORTS CAN CO-EXIST TOGETHER AND BOTH = BE INSTALLED =A0 =A0***" > > =A0@${ECHO_MSG} "******************************************************= ***************" > > =A0@sleep 10 > > .endif > > >=20 > I would suggest the following changes for net/fping: >=20 > - remove the ipv6 category from net/fping, since it is ipv4 only. >=20 > Change comment to: > COMMENT=3D Quickly ping N hosts w/o flooding the network - IPv4 Only vers= ion >=20 > - Remove this define from the ports Makefile: >=20 > .if defined(WITH_IPV6) > # IPv6 not enabled by default, as it does not work together with IPv4. > CFLAGS+=3D -DIPV6 > .endif >=20 > I also noticed that the net/fping includes a source address patch > (net/fping/files/patch-sourceaddr) that is missing in the > net/fping+ipv6 port. The patch seems to support both ipv4 or ipv6 > depending on if IPV6 is defined. >=20 Agreed. Either will do as it still has the same effect.=20 Thinking about this while at work and looking over the source for fping, it would be really nice if we snatched it up, modified it so ipv4+ipv6 worked together and then just slammed it into /usr/src/sbin/fping. The license is really permisable MIT like license and the code size is rather small. I think Solaris already has or has had a utility very similiar to the functionality of this and would make sense to to have it in our tree as well. Language files blank comments code ----------------------------------------------------- C 1 633 305 1804 ----------------------------------------------------- --=20 "Unity can only be manifested by the Binary. Unity itself and the idea of U= nity are already two." -- Buddha Regards, (jhell) Jason Hellenthal --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJN7Cx0AAoJEJBXh4mJ2FR+4ZkH/2zjhVMQzdiZtaykNwV3iOpN yGyAkU8GGF3ImCLW/9gpm0ejLC3WRepFLu5a8hAgAlX5JY6lGMyHlxyUXqB30Y6U dlMpwUfhB64jMhct8OofqGkbGja7pis3WguU/4VNvehYuiSn2DAho+Hpm5JuxpB1 nvuYS1PMvOuKKNI+Ejm+OOHkktnDOrtF8/RYGudGGZ27FZuKSdj1JvoV7QqRk5BY 084oJxdqD7j6bsK6oB/zHNfxJUL4SyThDC2vbCY8+SJDX5YwovjRtLUDNUmcGC+8 J8FcDIsSfn4nyfoJDUAKi1y6AX4QUst05Pm/DZAnQeX9W4zGMO/doNbGr9Qq4N4= =SR0y -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110606012509.GA14126>