Date: Mon, 10 Oct 2005 12:12:19 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: Peter Edwards <peadar@FreeBSD.org>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, S?ren Schmidt <sos@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c Message-ID: <13707.1128939139@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 10 Oct 2005 12:10:13 %2B0200." <20051010101013.GB3975@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20051010101013.GB3975@garage.freebsd.pl>, Pawel Jakub Dawidek write s: > >On Mon, Oct 10, 2005 at 11:06:49AM +0200, S?ren Schmidt wrote: >+> On 09/10/2005, at 23:11, Peter Edwards wrote: >+> >+> Why did you ask me to review this when you just committed it anyway ? >+> >+> As I said I'm not sure this is the right way to fix this.. > >It seems to be right. I do it in my GEOM classes to handle g_clone_bio() >failures better. So the only objection I may have is that it could be >done a bit cleaner: Please see geom_disk.c -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13707.1128939139>