Date: Mon, 22 Oct 2012 05:52:08 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, src-committers@freebsd.org, Jan Beich <jbeich@tormail.org> Subject: Re: svn commit: r241823 - in head: . etc etc/atf etc/mtree lib lib/atf lib/atf/libatf-c lib/atf/libatf-c++ libexec libexec/atf libexec/atf/atf-check share share/atf share/doc share/doc/atf share/exampl... Message-ID: <CAGH67wQqZG=Cb=mOxpQEn=577==FXyu_coX9_agxa%2B7niaKJtw@mail.gmail.com> In-Reply-To: <50852951.5000809@FreeBSD.org> References: <201210220118.q9M1Ifh5098857__14926.3614825488$1350868751$gmane$org@svn.freebsd.org> <1TQC0L-000AZG-Q5@internal.tormail.org> <50852951.5000809@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 22, 2012 at 4:09 AM, Dimitry Andric <dim@freebsd.org> wrote:
> On 2012-10-22 09:00, Jan Beich wrote:
> ...
>>
>> atf-run fails to link when using -stdlib=libc++. It works if I remove
>> `throw' from check_stream(). Any clue?
>>
>> test-program.o: In function `(anonymous
>> namespace)::check_stream(std::__1::basic_ostream<char,
>> std::__1::char_traits<char> >&)':
>>
>> /usr/src/usr.bin/atf/atf-run/../../../contrib/atf/atf-run/test-program.cpp:76:
>> undefined reference to `std::__1::basic_ios<char,
>> std::__1::char_traits<char> >::clear(unsigned int)'
>> clang++: error: linker command failed with exit code 1 (use -v to see
>> invocation)
>
>
> Strange, for me it compiles (with a bunch of warnings, which I have
> fixed locally), and links just fine. However, I always use -std=c++11,
> which -std= flag are you using, if any?
>
> That said, I am planning on importing a new drop of libc++ soon, but I
> would rather see this fixed sooner than later. So I will cherry-pick
> a few fixes tonight.
>
> Meanwhile, here are the local diffs I have for making atf build.
>
> -Dimitry
>
> PS: As far as I can see, atf doesn't build at all with clang and
> libstdc++, because there are many warnings caused by -Wsystem-headers...
> Is there any incentive to fix these?
I submitted the atf compile-time warnings patch on your behalf:
http://code.google.com/p/kyua/issues/detail?id=42&thanks=42&ts=1350910277
.
Thanks!
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQqZG=Cb=mOxpQEn=577==FXyu_coX9_agxa%2B7niaKJtw>