Date: Sun, 25 Jul 2010 22:25:52 +0000 (UTC) From: Jilles Tjoelker <jilles@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/bin/sh parser.c src/tools/regression/bin/sh/parser heredoc7.0 Message-ID: <201007252231.o6PMVAw3021928@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jilles 2010-07-25 22:25:52 UTC
FreeBSD src repository
Modified files:
bin/sh parser.c
Added files:
tools/regression/bin/sh/parser heredoc7.0
Log:
SVN rev 210488 on 2010-07-25 22:25:52Z by jilles
sh: Fix crash due to uninitialized here-document.
If an ; or & token was followed by an EOF token, pending here-documents were
left uninitialized. Execution would crash, either in the main shell process
for literal here-documents or in a child process for expanded
here-documents. In the latter case the problem is hard to detect apart from
the core dumps and log messages.
Side effect: slightly different retries on inputs where EOF is not
persistent.
Note that tools/regression/bin/sh/parser/heredoc6.0 still causes a similar
crash in a child process. The text passed to eval is malformed and should be
rejected.
Revision Changes Path
1.85 +3 -0 src/bin/sh/parser.c
1.1 +19 -0 src/tools/regression/bin/sh/parser/heredoc7.0 (new)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007252231.o6PMVAw3021928>