Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Jan 2021 06:53:12 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 51bf55fa6c78 - main - cache: stop checkpointing cn_namelen
Message-ID:  <202101030653.1036rCU0023135@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=51bf55fa6c780734b201f22b5f6ee4092fd979ef

commit 51bf55fa6c780734b201f22b5f6ee4092fd979ef
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-01-01 13:45:06 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2021-01-03 06:50:06 +0000

    cache: stop checkpointing cn_namelen
    
    The variable is recomputed by regular lookup from the get go.
---
 sys/kern/vfs_cache.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index 396969bb10ec..2773ed76036c 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -3582,7 +3582,6 @@ SYSCTL_BOOL(_vfs, OID_AUTO, cache_fast_lookup, CTLFLAG_RW,
  * need restoring in case fast path lookup fails.
  */
 struct nameidata_saved {
-	long cn_namelen;
 	char *cn_nameptr;
 	size_t ni_pathlen;
 	int cn_flags;
@@ -3642,7 +3641,6 @@ cache_fpl_checkpoint(struct cache_fpl *fpl, struct nameidata_saved *snd)
 {
 
 	snd->cn_flags = fpl->ndp->ni_cnd.cn_flags;
-	snd->cn_namelen = fpl->ndp->ni_cnd.cn_namelen;
 	snd->cn_nameptr = fpl->ndp->ni_cnd.cn_nameptr;
 	snd->ni_pathlen = fpl->ndp->ni_pathlen;
 }
@@ -3652,7 +3650,6 @@ cache_fpl_restore_partial(struct cache_fpl *fpl, struct nameidata_saved *snd)
 {
 
 	fpl->ndp->ni_cnd.cn_flags = snd->cn_flags;
-	fpl->ndp->ni_cnd.cn_namelen = snd->cn_namelen;
 	fpl->ndp->ni_cnd.cn_nameptr = snd->cn_nameptr;
 	fpl->ndp->ni_pathlen = snd->ni_pathlen;
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202101030653.1036rCU0023135>