Date: Sat, 22 Oct 2016 18:23:11 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Guy Yur <guyyur@gmail.com> Cc: freebsd-current <freebsd-current@freebsd.org>, emaste@freebsd.org Subject: Re: installworld fails on missing tzsetup when WITHOUT_DIALOG is set Message-ID: <20161022162311.d7ewekapcuiubuxh@ivaldir.etoilebsd.net> In-Reply-To: <CAC67Hz_WkF=gLB%2BWozYLQJPM7YpkQyQZ=c_bUoYRLKcb0-BgTg@mail.gmail.com> References: <CAC67Hz_WkF=gLB%2BWozYLQJPM7YpkQyQZ=c_bUoYRLKcb0-BgTg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--so7woetn35mr5jwj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Oct 22, 2016 at 06:51:28PM +0300, Guy Yur wrote:
> Hi,
>=20
> installworld fails on missing tzsetup when src.conf has WITHOUT_DIALOG=3D
> and delete-old was previously run to remove tzsetup from the system.
>=20
> mkdir -p /tmp/install.8gNIwAFV
> progs=3D$(for prog in [ awk cap_mkdb cat chflags chmod chown cmp cp
> date echo egrep find grep id install ln make mkdir mtree mv pwd_mkdb
> rm sed services_mkdb sh strip sysctl test true uname wc zic tzsetup
> makewhatis; do if progpath=3D`which $prog`; then echo $progpath; else
> echo "Required tool $prog not found in PATH." >&2; exit 1; fi;
> done); libs=3D$(ldd -f "%o %p\n" -f "%o %p\n" $progs 2>/dev/null | sort
> -u | while read line; do set -- $line; if [ "$2 $3" !=3D "not found"
> ]; then echo $2; else echo "Required library $1 not found." >&2;
> exit 1; fi; done); cp $libs $progs /tmp/install.8gNIwAFV
> Required tool tzsetup not found in PATH.
> *** Error code 1
>=20
> tzsetup is used in share/zoneinfo/Makefile when ${DESTDIR}/var/db/zoneinfo
> exists and some other conditions.
>=20
> In my case, I don't have /var/db/zoneinfo since I manually created a syml=
ink
> from /usr/share/zoneinfo/... to /etc/localtime instead of using tzsetup.
>=20
> A possible fix is to add a WITHOUT_TZSETUP knob and not use
> tzsetup when the knob is enabled.
>=20
> https://github.com/guyyur/freebsd-src_patches/blob/master/without_tzsetup=
_knob.patch
> (patch doesn't include regenerating src.conf.5)
>=20
> Thanks,
> Guy
> _______________________________________________
My proposal is a bit different: build tzsetup without dialog support :)
https://reviews.freebsd.org/D8325
Best regards,
Bapt
--so7woetn35mr5jwj
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJYC5JmAAoJEGOJi9zxtz5a0KYQAKC5R8ArPsTxBf9270sJEi13
38FlYzrQTkSIR88tthpV25qf2ans11KYO3XLfDKd/eZ0cN13ND2SiOt5AQeh4DVk
fWV0UXJfkknKbOU777sLP3LIIFatYA1z7pMHXVN17IVhM+2ASkmLV9kh8Qr0neZ9
WEYzvZxWYbMLPp0mxk9pwWP7Zx0jBG3apCF0RmBfnCkRB48aAkBxnQinGJ1QLpjM
8n9eaBy5PRK5Bu/kEwbzODro+RU2DugcOuvGXiECzqQSWff52gXTj0Cx7E+xie4j
c7cO6tOIO1KOmiPEKibzGacoX40RTvsR1ZYSqWAvKClqVzHMPp3+8Ymdl9/UDDcM
s9i2/We90Z2WiIc+ixE0qN0e7jDOYc2AOSEZsWep0/CnzDyXL2CgX87JC8lJVwpn
hR/VDZqbQlfHc0l2/hDsaLAqFcKNlbbmag4t1eRg24mqVW0u2m7p/owqesThy9oF
Wreu9ABD8KRlNcmJdzoVYbRD2H760BoJG5nWi8GPTqcD9fd5S4o0icIB8BkPLQcP
wktcGhLJ90hO7hRI3bO6EjJVcyujjJOkz751b/5gBugeH0rklTK37EONU2b++6U/
KpOw/B8O9a8MjmTwvwv69aLcn/fZxQ8aNYp8TQWSdpWFJNoy4DF35MJEBJLl75g3
NuKbsra1PV2SHL1icHnE
=9Uh3
-----END PGP SIGNATURE-----
--so7woetn35mr5jwj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161022162311.d7ewekapcuiubuxh>