Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Mar 2024 20:02:19 -0700
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Colin Percival <cperciva@tarsnap.com>
Cc:        John Baldwin <jhb@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: a16ff32f04b5 - main - NFS: Request use of TCP_USE_DDP for  in-kernel TCP sockets
Message-ID:  <20240321030219.CF3AE28F@slippy.cwsent.com>
In-Reply-To: <0100018e5ed59116-ed05047b-c4ef-4363-b740-46148241b8a8-000000@email.amazonses.com>
References:  <202403202234.42KMYdvE047953@gitrepo.freebsd.org>  <0100018e5ed59116-ed05047b-c4ef-4363-b740-46148241b8a8-000000@email.amazonses.com>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <0100018e5ed59116-ed05047b-c4ef-4363-b740-46148241b8a8-000000@ema
il.
amazonses.com>, Colin Percival writes:
> On 3/20/24 15:34, John Baldwin wrote:
> > The branch main has been updated by jhb:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=a16ff32f04b5b891a2d9b0427a2fd9
> c48e866da3
> > 
> > commit a16ff32f04b5b891a2d9b0427a2fd9c48e866da3
> > Author:     John Baldwin <jhb@FreeBSD.org>
> > AuthorDate: 2024-03-20 22:29:51 +0000
> > Commit:     John Baldwin <jhb@FreeBSD.org>
> > CommitDate: 2024-03-20 22:29:51 +0000
> > 
> >      NFS: Request use of TCP_USE_DDP for in-kernel TCP sockets
>
> I think this commit broke buildworld:
>
> > In file included from /releng/15-i386-GENERIC-snap/usr/src/lib/libsysdecode
> /flags.c:82:
> > /releng/15-i386-GENERIC-snap/tmp/obj/releng/15-i386-GENERIC-snap/usr/src/i3
> 86.i386/lib/libsysdecode/tables.h:1323:13: error: use of undeclared identifie
> r 'TCP_USE_DDP'
> >  1323 | TABLE_ENTRY(TCP_USE_DDP)
> >       |             ^
> > /releng/15-i386-GENERIC-snap/usr/src/lib/libsysdecode/flags.c:79:21: note: 
> expanded from macro 'TABLE_ENTRY'
> >    79 | #define TABLE_ENTRY     X
> >       |                         ^
> > 1 error generated.
>
> -- 
> Colin Percival
> FreeBSD Release Engineering Lead & EC2 platform maintainer
> Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
>

3d0a736796a9 broke the build. TCP_USE_DDP is enclosed in #ifdef KERNEL 
breaking this userland build. I've temporarily commented out the #ifdef 
bracketing here to allow my builds to continue for now.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240321030219.CF3AE28F>