Date: Sun, 8 Apr 2018 02:39:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Conrad Meyer <cem@freebsd.org> Cc: Roger Pau Monn?? <royger@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86 Message-ID: <20180408023934.GA85042@FreeBSD.org> In-Reply-To: <CAG6CVpV8Ue-t--%2BMMS%2B11x_=LjgWbQiAq2KGzOEdiGPpxQ%2BPhQ@mail.gmail.com> References: <201804061120.w36BK6s6074635@repo.freebsd.org> <CAG6CVpV8Ue-t--%2BMMS%2B11x_=LjgWbQiAq2KGzOEdiGPpxQ%2BPhQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 06, 2018 at 07:14:42AM -0700, Conrad Meyer wrote: > I like something like this for clarity. But I don't see any reason > for these function-like macros instead of the more general definition > of an SI prefix constant multiple. A multiple works with numeric > literals and variables alike. Something like: As Bruce had said, 1G is normally written as 1024 * 1024 * 1024 and this is clearer than 1 << 30. Macros/functions like these are evil and bring more problems than they solve (again, as Bruce had explained). GiB name is also ugly (correct spelling is GB). IMHO the whole thing should just be removed. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180408023934.GA85042>