Date: Tue, 26 Oct 2010 22:03:54 -0700 From: Devin Teske <dteske@vicor.com> To: freebsd-sysinstall@freebsd.org Subject: cpioVerbose=medium broken because cpio(1) no longer accepts -V/--dot Message-ID: <819FEF05-0F22-42E7-9F38-E363A3B2E541@vicor.com>
next in thread | raw e-mail | index | archive | help
Hello fellow sysinstall-hackers,
I've been working on some new additions to sysinstall and in performing =
some tests, I came across a rather odd situation.
I threw "cpioVerbose=3Dmedium" into our install.cfg file for =
sysinstall(8) and it barfed up an error while trying to unpack the split =
tarballs (blah blah "cpio exited with error status: 1").
Upon closer investigation, it appears that cpio(1) no longer supports =
the "-V" flag which used to print a single "." for each file processed.
This is rather unfortunate because it now means that we're limited to =
passing "-v" for full verbosity or no "-v" for no output, nothing =
in-between like "-V" or "--dot" from the old FreeBSD-4.11 cpio.
Although I'd rather see cpio(1) patched to once-again support a =
medium-verbosity option, I think maybe it's come to the point where we =
take this out of sysinstall.
Here's the unified patch of the three files that need patching to =
deprecate the use of `-V' in sysinstall(8) (comments welcome):
--- usr.sbin/sysinstall/help/shortcuts.hlp.orig 2007-06-25 =
09:37:17.000000000 -0700
+++ usr.sbin/sysinstall/help/shortcuts.hlp 2010-10-26 =
15:37:45.000000000 -0700
@@ -13,7 +13,7 @@ blanktime Screen blank tim
bootManager Select boot manager: booteasy, standard or none
browserBinary Which doc browser to use (default: links)
browserPackage Which package to get browser from (default: =
links)
-cpioVerbose How verbose to be with cpio: high, medium or =
low
+cpioVerbose How verbose to be with cpio: high or low
debug Extra debugging?
defaultrouter IP address of default route
disk Which disk to operate on (ad0, da0, etc).
--- usr.sbin/sysinstall/media.c.orig 2010-06-13 19:09:06.000000000 =
-0700
+++ usr.sbin/sysinstall/media.c 2010-10-26 15:51:06.000000000 -0700
@@ -117,8 +117,6 @@ cpioVerbosity()
=20
if (cp && !strcmp(cp, "high"))
return "-v";
- else if (cp && !strcmp(cp, "medium"))
- return "-V";
return "";
}
=20
@@ -848,8 +846,6 @@ mediaSetCPIOVerbosity(dialogMenuItem *se
}
else {
if (!strcmp(cp, "low"))
- variable_set2(VAR_CPIO_VERBOSITY, "medium", 0);
- else if (!strcmp(cp, "medium"))
variable_set2(VAR_CPIO_VERBOSITY, "high", 0);
else /* must be "high" - wrap around */
variable_set2(VAR_CPIO_VERBOSITY, "low", 0);
--- usr.sbin/sysinstall/sysinstall.8.orig 2010-06-13 =
19:09:06.000000000 -0700
+++ usr.sbin/sysinstall/sysinstall.8 2010-10-26 15:57:21.000000000 =
-0700
@@ -749,8 +749,7 @@
.Sy Variables :
.Bl -tag -width indent
.It cpioVerbose
-Can be used to set the verbosity of cpio extractions to low, medium or
-high.
+Can be used to set the verbosity of cpio extractions to low or high.
.El
.It mediaGetType
Interactively get the user to specify some type of media.
P.S. It should be noted that cpioVerbose=3Dhigh and cpioVerbose=3Dlow =
both work as expected.
--
Cheers,
Devin Teske
-> CONTACT INFORMATION <-
Business Solutions Consultant II
FIS - fisglobal.com
510-735-5650 Mobile
510-621-2038 Office
510-621-2020 Office Fax
909-477-4578 Home/Fax
devin.teske@fisglobal.com
-> LEGAL DISCLAIMER <-
This message contains confidential and proprietary information
of the sender, and is intended only for the person(s) to whom it
is addressed. Any use, distribution, copying or disclosure by any
other person is strictly prohibited. If you have received this
message in error, please notify the e-mail sender immediately,
and delete the original message without making a copy.
-> FUN STUFF <-
-----BEGIN GEEK CODE BLOCK-----
Version 3.1
GAT/CS d(+) s: a- C++(++++) UB++++$ P++(++++) L++(++++) !E--- W++ N? o? =
K- w O
M+ V- PS+ PE Y+ PGP- t(+) 5? X+(++) R>++ tv(+) b+(++) DI+(++) D(+) G+>++ =
e>+ h
r>++ y+=20
------END GEEK CODE BLOCK------
http://www.geekcode.com/
-> END TRANSMISSION <-
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?819FEF05-0F22-42E7-9F38-E363A3B2E541>