Date: Thu, 31 Jul 2008 11:20:39 -0400 From: John Baldwin <jhb@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/vm swap_pager.c Message-ID: <200807311120.40094.jhb@freebsd.org> In-Reply-To: <20080731090651.GX97161@deviant.kiev.zoral.com.ua> References: <200807302112.m6ULCThe046074@repoman.freebsd.org> <20080731090651.GX97161@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 31 July 2008 05:06:51 am Kostik Belousov wrote: > On Wed, Jul 30, 2008 at 09:12:15PM +0000, John Baldwin wrote: > > jhb 2008-07-30 21:12:15 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/vm swap_pager.c > > Log: > > SVN rev 181019 on 2008-07-30 21:12:15Z by jhb > > > > If the kernel has run out of metadata for swap, then explicitly panic() > > instead of emitting a warning before deadlocking. > > > > MFC after: 1 month > > > > Revision Changes Path > > 1.303 +1 -1 src/sys/vm/swap_pager.c > > Hmm, would it make sense to attempt to sync the filesystems ? We > panic due to resource exhaustion as opposed to some data consistency > violation. Sure, sync might deadlock too, because we may be in the low > memory condition. There is already a 'sync on panic' option for the brave. :) What would really be a better fix is if this condition could be treated the same as running out of swap space (i.e. go kill a process and keep running). I would have done that in the first place instead of adding the printf if it was easy. :) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807311120.40094.jhb>