Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 09 Oct 2002 19:10:50 +0100
From:      Ian Dowse <iedowse@maths.tcd.ie>
To:        Ceri Davies <ceri@FreeBSD.org>
Cc:        walterk1@earthlink.net, freebsd-bugs@FreeBSD.org
Subject:   Re: bin/43865: unterminated string in rc.conf leaves system unuseable / disk readonly 
Message-ID:   <200210091910.aa71736@salmon.maths.tcd.ie>
In-Reply-To: Your message of "Wed, 09 Oct 2002 10:13:02 PDT." <200210091713.g99HD2Ut063553@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help

In message <200210091713.g99HD2Ut063553@freefall.freebsd.org>, Ceri Davies writ
es:
>State-Changed-From-To: open->closed
>Pilot error.
>
>/etc/rc.conf is sourced by /bin/sh, and therefore must be in valid
>/bin/sh syntax.
>
>If you have garbled /etc/rc.conf (or any of the other startup files),
>this does not mean that you have to reinstall the system - boot into
>single user and correct the error.

I actually think that this is a perfectly reasonable bug report.
It is far too easy to miss a quote in rc.conf, yet the file would
rarely contain more than name="value" lines. That's a lot of
foot-shooting potential for very little gain, and is especially
problematic when making configuration changes remotely.

We could relatively easily change to parsing rc.conf line-by-line,
and allow more complex sh commands only in additional rc files
defined by some rc.conf variable, i.e. we could keep the flexibility
we have now, but significantly increase the robustness to common
typos.

Ian

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210091910.aa71736>