Date: Wed, 27 Apr 2022 19:26:32 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: fa160738bd18 - main - firewire: Initialize firewire_devclass in fw_modevent. Message-ID: <202204271926.23RJQW1U047775@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=fa160738bd18db58b811ed6716330527416f2eda commit fa160738bd18db58b811ed6716330527416f2eda Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2022-04-27 19:26:05 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2022-04-27 19:26:05 +0000 firewire: Initialize firewire_devclass in fw_modevent. The use of devclass_get_softc() combined with cdev unit numbers is probably not ideal (probably should be initializing si_drv1 when each cdev is created instead), but it looks like a bit of a PITA to do, so just initialize the devclass explicitly instead. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D35060 --- sys/dev/firewire/firewire.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/firewire/firewire.c b/sys/dev/firewire/firewire.c index 45f3ac3cb79d..cfcc41d60c1c 100644 --- a/sys/dev/firewire/firewire.c +++ b/sys/dev/firewire/firewire.c @@ -2368,6 +2368,7 @@ fw_modevent(module_t mode, int type, void *data) switch (type) { case MOD_LOAD: + firewire_devclass = devclass_create("firewire"); fwdev_ehtag = EVENTHANDLER_REGISTER(dev_clone, fwdev_clone, 0, 1000); break; @@ -2384,6 +2385,5 @@ fw_modevent(module_t mode, int type, void *data) } -DRIVER_MODULE(firewire, fwohci, firewire_driver, firewire_devclass, - fw_modevent,0); +DRIVER_MODULE(firewire, fwohci, firewire_driver, fw_modevent, NULL); MODULE_VERSION(firewire, 1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204271926.23RJQW1U047775>