Date: Sun, 14 Dec 2003 09:30:19 -0800 (PST) From: Josef El-Rayes <josef@daemon.li> To: freebsd-doc@FreeBSD.org Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook Message-ID: <200312141730.hBEHUJrs024860@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/60107; it has been noted by GNATS. From: Josef El-Rayes <josef@daemon.li> To: Lukas Ertl <l.ertl@univie.ac.at> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook Date: Wed, 10 Dec 2003 10:00:36 +0000 Lukas Ertl <l.ertl@univie.ac.at> wrote: > +#include <sys/param.h> /* defines used in kernel.h */ > -#include <sys/param.h> /* defines used in kernel.h */ hi lukas! it is a good idea to have a look at the diff-generated patch before sending in, to avoid bogus lines like this. for example when you move a line(i.e. remove & insert at another place), you get such behaviour in your patch which makes it hard to read. keep up the good work :) greets, josef
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312141730.hBEHUJrs024860>