Date: Tue, 4 Mar 2008 16:32:41 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 136825 for review Message-ID: <200803041632.m24GWfoF014777@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=136825 Change 136825 by rwatson@rwatson_freebsd_capabilities on 2008/03/04 16:32:15 Add a comment to uipc_usrreq.c relating to UNIX domain socket GC in the capabilities world order. Affected files ... .. //depot/projects/trustedbsd/capabilities/src/sys/kern/uipc_usrreq.c#2 edit Differences ... ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/uipc_usrreq.c#2 (text+ko) ==== @@ -1939,6 +1939,11 @@ * Check for a socket potentially in a cycle. It must be in a * queue as indicated by msgcount, and this must equal the file * reference count. Note that when msgcount is 0 the file is NULL. + * + * XXXRW: This will need to change to also look at the capabilities + * referencing the file descriptor. It must: (a) subtract the number + * of capability references, and (b) add the non-message references + * to the capabilities themselves. */ if ((unp->unp_gcflag & UNPGC_REF) == 0 && fp && unp->unp_msgcount != 0 && fp->f_count == unp->unp_msgcount) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803041632.m24GWfoF014777>