Date: Tue, 23 Aug 2011 16:30:56 -0400 From: Greg Larkin <glarkin@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, C-S <c-s@c-s.li>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/hiawatha Makefile ports/www/hiawatha/files hiawatha.in php-fcgi.in pkg-message.in Message-ID: <4E540E00.1030609@FreeBSD.org> In-Reply-To: <4E5409AE.9050400@FreeBSD.org> References: <201108232003.p7NK3ZQx066601@repoman.freebsd.org> <4E5409AE.9050400@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 8/23/11 4:12 PM, Doug Barton wrote:
> The rc.d script looks good, thanks!
>
> The only thing I would do differently is instead of having 2 separate lines:
>
> : ${hiawatha_pidfile="/var/run/hiawatha.pid"}
> pidfile=${hiawatha_pidfile}
>
> Do it like this:
>
> pidfile=${hiawatha_pidfile="/var/run/hiawatha.pid"}
>
> But that's really a micro-optimization.
>
>
> Thanks again,
>
> Doug
>
Nice job, Carlo! We can add that change on the next hiawatha update.
Cheers,
Greg
- --
Greg Larkin
http://www.FreeBSD.org/ - The Power To Serve
http://www.sourcehosting.net/ - Ready. Set. Code.
http://twitter.com/cpucycle/ - Follow you, follow me
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk5UDgAACgkQ0sRouByUApDUnwCeLlA3mrm+8bHB7f8tqSkmOZiP
lskAn0An2pU2ahPY4joFDWi4c68vINrd
=RrI1
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E540E00.1030609>