Date: Wed, 4 Apr 2007 17:24:50 GMT From: Oleksandr Tymoshenko <gonzo@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 117378 for review Message-ID: <200704041724.l34HOocf013038@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=117378 Change 117378 by gonzo@gonzo_jeeves on 2007/04/04 17:24:18 o Retire SYF_ARGMASK and remove both SYF_MPSAFE and SYF_ARGMASK. Affected files ... .. //depot/projects/mips2/src/sys/mips/mips/trap.c#18 edit Differences ... ==== //depot/projects/mips2/src/sys/mips/mips/trap.c#18 (text+ko) ==== @@ -375,7 +375,6 @@ u_int nargs, i; register_t *args, copyargs[MAXARGS]; struct sysent *callp; - int locked = 0; int args_shift = 0; int quad_syscall = 0; register_t ov0, opc; @@ -424,7 +423,7 @@ callp = &p->p_sysent->sv_table[0]; else callp = &p->p_sysent->sv_table[code]; - nargs = callp->sy_narg & SYF_ARGMASK; + nargs = callp->sy_narg; /* Copy arguments from a0..a4 */ for(i = 0; i < MIN(nargs, 4 - args_shift); i++) @@ -459,9 +458,6 @@ CTR4(KTR_SYSC, "syscall enter thread %p pid %d proc %s code %d", td, td->td_proc->p_pid, td->td_proc->p_comm, code); - if ((callp->sy_narg & SYF_MPSAFE) == 0) - mtx_lock(&Giant); - locked = 1; if (error == 0) { td->td_retval[0] = 0; td->td_retval[1] = 0; @@ -513,9 +509,6 @@ break; } - if (locked && (callp->sy_narg & SYF_MPSAFE) == 0) - mtx_unlock(&Giant); - WITNESS_WARN(WARN_PANIC, NULL, "System call %s returning", (code >= 0 && code < SYS_MAXSYSCALL) ? syscallnames[code] : "???"); KASSERT(td->td_critnest == 0,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704041724.l34HOocf013038>