Date: 20 Jun 2002 12:39:51 +0200 From: Jan Stocker <jstocker@tzi.de> To: Sean Chittenden <sean@chittenden.org> Cc: Joe Marcus Clarke <marcus@marcuscom.com>, Kris Kennaway <kris@obsecurity.org>, walt <wsheets@sbcglobal.net>, freebsd-current <freebsd-current@FreeBSD.ORG> Subject: Re: The -current state of mozilla affairs Message-ID: <1024569592.1148.12.camel@twoflower> In-Reply-To: <20020619232135.D37593@ninja1.internal> References: <3CFC588A.9070903@sbcglobal.net> <20020604134655.B62465@xor.obsecurity.org> <20020619183056.K31745@ninja1.internal> <1024539159.44782.21.camel@shumai.marcuscom.com> <20020619232135.D37593@ninja1.internal>
next in thread | previous in thread | raw e-mail | index | archive | help
The attached patch works quite fine here on my system ! On Thu, 2002-06-20 at 08:21, Sean Chittenden wrote: > > > I supped a -CURRENT system 3 days ago and am still having the problem > > > described here, but the gcc that's in the base system is 3.1 at this > > > point. I'm installing gcc32 now and will try building this again > > > using a newer version of GCC but am not sure if this'll fix anything. > > > Anyone have any ideas/clues? -sc > > > > I do, but admittedly, it's not my idea. Peter Kostouros has said > > that defining THUNK_BASED_THIS_ADJUST in > > xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h fixes > > the build problem on -CURRENT. I have not tested this yet, but I > > did test a build with gcc31 from ports (per mbr@'s suggestion), and > > that works just fine. > > > > I want to test Peter's suggestion before I add more bloat to Mozilla. I > > just have a really slow -CURRENT machine. If you'd like to test the > > option, undefine CFRONT_STYLE_THIS_ADJUST, and define > > THUNK_BASED_THIS_ADJUST in the above header file, and see if it works. > > Sweeet! We've got a winner. The attach patched should work but is > untested (I just brute-forced the defs earlier and am not about to > wait another 4+hrs to test this little patch). :~) Anyway, any chance > this could be committed as a patch for mozilla? -sc > > -- > Sean Chittenden > ---- > > --- xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h.orig Tue Apr 9 20:37:34 2002 > +++ xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h Wed Jun 19 23:23:38 2002 > @@ -94,7 +94,7 @@ > * gcc is that the system gcc defines __FreeBSD_cc_version. This variable > * can also identify the period of time that 4.0-CURRENT used thunks. > */ > -#if defined(__FreeBSD_cc_version) && \ > + #if defined(__FreeBSD_cc_version) && (__FreeBSD_cc_version < 500003) && \ > (__FreeBSD_cc_version < 400002 || __FreeBSD_cc_version > 400003) > #define CFRONT_STYLE_THIS_ADJUST > #else To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1024569592.1148.12.camel>