Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Mar 2007 11:21:15 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Jung-uk Kim <jkim@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/mii brgphy.c
Message-ID:  <20070320111650.C6064@besplex.bde.org>
In-Reply-To: <200703192317.l2JNHd59062213@repoman.freebsd.org>
References:  <200703192317.l2JNHd59062213@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 19 Mar 2007, Jung-uk Kim wrote:

> jkim        2007-03-19 23:17:39 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/dev/mii          brgphy.c
>  Log:
>  Revert couple of changes from 1.51 and 1.52.  Reading link status with BMSR
>  is okay for most of the chipsets but BCM5701 PHY does not seem to like it.
>  Set media to IFM_NONE if link is not up instead of the previous value.
>
>  Reported by:    Goran Lowkrantz (goran dot lowkrantz at ismobile dot com)
>
>  Revision  Changes    Path
>  1.66      +12 -14    src/sys/dev/mii/brgphy.c

Does this fix the problem that reading the link status causes input errors?
oleg@ has a large patch which avoids this problem by not always reading the
link status in bge_tick().  I use a simpler verion of this.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070320111650.C6064>