Date: Sat, 12 May 2018 01:31:19 -0400 From: Allan Jude <allanjude@freebsd.org> To: Oleksandr Tymoshenko <gonzo@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r333503 - stable/11/sys/net Message-ID: <5db6b500-8c4c-d171-4418-5e25c510f66d@freebsd.org> In-Reply-To: <20180512051543.GA8131@bluezbox.com> References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com> <1526081817.2597.5.camel@freebsd.org> <20180512051543.GA8131@bluezbox.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uV4rTWLqWNWce1EYzanASLYijBtBCJsF4 Content-Type: multipart/mixed; boundary="NAX9ZmWMvFU6YjSjjjXX16y2OBGHrOGf8"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: Oleksandr Tymoshenko <gonzo@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Message-ID: <5db6b500-8c4c-d171-4418-5e25c510f66d@freebsd.org> Subject: Re: svn commit: r333503 - stable/11/sys/net References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com> <1526081817.2597.5.camel@freebsd.org> <20180512051543.GA8131@bluezbox.com> In-Reply-To: <20180512051543.GA8131@bluezbox.com> --NAX9ZmWMvFU6YjSjjjXX16y2OBGHrOGf8 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-05-12 01:15, Oleksandr Tymoshenko wrote: > Ian Lepore (ian@freebsd.org) wrote: >> On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: >>> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd@freebsd.org> wro= te: >>>> >>>> >>>> Author: shurd >>>> Date: Fri May 11 20:40:26 2018 >>>> New Revision: 333503 >>>> URL: https://svnweb.freebsd.org/changeset/base/333503 >>>> >>>> Log: >>>> =C2=A0 MFC r333329, r333366, r333373 >>>> >>>> =C2=A0 r333329: Fix off-by-one error requesting tx interrupt >>>> =C2=A0 r333366: Cleanup queues when iflib_device_register fails >>>> =C2=A0 r333373: Log iflib_tx_structures_setup failure in function >>>> >>> Is this an acceptable style for MFC logs? >>> >>> I'm asking because I actually prefer this to reading (or compiling) t= he >>> concatenated log messages from several changes. However, I never knew= it >>> was acceptable to summarize like this. If it is, I'd like to know so = I can >>> adopt it for run-of-the-mill MFCs. >>> >>> Jonathan >> >> This used to be my preferred format, essentially to summarize what's >> being mfc'd. But then I started using the MFC Tracker tool [*] and it >> automatically generates a commit message that contains the full text, >> so I stopped trying to summarize things. >=20 > I've just deployed new mfctracker version with summarized MFC commit > message support so users can now switch between full MFC log and a > short version. Of course it's only useful if selected commits have > one-line summary in the first line of a commit message. > =20 >> [*]=C2=A0https://mfc.kernelnomicon.org/6/ >> >> -- Ian >=20 Thank you for building and constantly improving this extremely useful too= l. --=20 Allan Jude --NAX9ZmWMvFU6YjSjjjXX16y2OBGHrOGf8-- --uV4rTWLqWNWce1EYzanASLYijBtBCJsF4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJa9nwqAAoJEBmVNT4SmAt+AgIQAJ2QnpbuJwU+t3DmUbR0Tj0K 9oB6JE+EXisoXaQ5rI1LgnIzbSxbVFeUhwS4WGJxuqhNarS6XO1EuZgYgNeOW1oi 1e3wAWoqwsJQtHhJ21OqD4Gvc0KRTlb2P5so2kxNgExwpC8lZ/fXE7e3L5H5ucfN ysG3c9xp8MfmR0Xb17wdV3cfhwNAFBuyQuN9ndwhpqVddl5l6rg3nr82qWQOvb1I q5sYiZ7rSJ05+QHEOiy+yPwT0lBvSdNXbaBIKOvA2W6HzpqGOL6voZ7zK9ALZAMI 1VWKEXs8CEWNfB7PAuWemqpMjXSDJ39gmsyRqu93B9g5J7BPfupJa6/uWiY8PKxG gH3Uy/xlxUJBV+MOfGf39OtC2E3Dnu0mOL+G6XjCKruWhHyT3RgNVlyfNTkes1IR X8+O7DRozOYhBawMtDcl0Cr3J8mkL+p3jIAL+RWrapz76+02yoAeBGJzmKw2z1Vo zp9u8CWxQiLGG9wxqcbm+HoaLZb6iUlxNqt1tWlc26qqb614p0eyb8d1LogeKU2K ufkDCob8hUcqBnpzVoD+57CPP5yJformnWQiTZpEbXN+8SL3MpJXjH1SpvsmfisF CpZBTYTpNGV2MgjIYgfPHp3LalV9zJfri4tp2NlWD6N9fkhT6kJAxa1R5shf5JO9 hYOhzIgB8Q+EAqOfztDi =O8eA -----END PGP SIGNATURE----- --uV4rTWLqWNWce1EYzanASLYijBtBCJsF4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5db6b500-8c4c-d171-4418-5e25c510f66d>