Date: Thu, 16 Dec 2010 19:40:02 -0700 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <gcooper@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, "David E. O'Brien" <obrien@FreeBSD.org> Subject: Re: svn commit: r216493 - head/sbin/geom/class/eli Message-ID: <4D0ACD82.3030303@bsdimp.com> In-Reply-To: <AANLkTinpdt8UqKd1Ot2SU5bGfe1jULorrG_sC=vBwUCa@mail.gmail.com> References: <201012161754.oBGHsu5d071652@svn.freebsd.org> <AANLkTinpdt8UqKd1Ot2SU5bGfe1jULorrG_sC=vBwUCa@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/16/2010 11:54, Garrett Cooper wrote: > On Thu, Dec 16, 2010 at 9:54 AM, David E. O'Brien<obrien@freebsd.org> wrote: >> Author: obrien >> Date: Thu Dec 16 17:54:56 2010 >> New Revision: 216493 >> URL: http://svn.freebsd.org/changeset/base/216493 >> >> Log: >> Revert r216473. >> WARNS=6 causes "warning: cast increases required alignment of target type" >> on arm, ia64, mips, and sparc64. >> >> Modified: >> head/sbin/geom/class/eli/Makefile >> >> Modified: head/sbin/geom/class/eli/Makefile >> ============================================================================== >> --- head/sbin/geom/class/eli/Makefile Thu Dec 16 17:14:37 2010 (r216492) >> +++ head/sbin/geom/class/eli/Makefile Thu Dec 16 17:54:56 2010 (r216493) >> @@ -11,7 +11,7 @@ SRCS+= sha2.c >> DPADD= ${LIBMD} ${LIBCRYPTO} >> LDADD= -lmd -lcrypto >> >> -WARNS?= 6 >> +WARNS?= 3 >> >> CFLAGS+=-I${.CURDIR}/../../../../sys > I think it's actually safe to bump it to WARNS = 6 if you define > NO_WCAST_ALIGN = 1, but that would need to be tested. And the code in question needs to be audited to make sure that the alignment changes are benign. Blindly setting this just papers over the bugs... Warner > Cheers, > -Garrett > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D0ACD82.3030303>