Date: Sun, 3 Jul 2011 08:25:20 +1000 From: Peter Jeremy <peterjeremy@acm.org> To: Ben Kaduk <minimarmot@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r223722 - in head/sys: kern sys Message-ID: <20110702222520.GA28815@server.vk2pj.dyndns.org> In-Reply-To: <CAK2BMK4r35vYH1wB_jCyxQ%2B0vpu6ZaCYA=vLrF%2B5=B3pwhyo=A@mail.gmail.com> References: <201107021354.p62DsKnm042696@svn.freebsd.org> <CAK2BMK4r35vYH1wB_jCyxQ%2B0vpu6ZaCYA=vLrF%2B5=B3pwhyo=A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Jul-02 11:13:57 -0400, Ben Kaduk <minimarmot@gmail.com> wrote: >On Sat, Jul 2, 2011 at 9:54 AM, Ed Schouten <ed@freebsd.org> wrote: >> =A0Reintroduce the cioctl() hook in the TTY layer for digi(4). Thanks Ed. >> =A0The cioctl() hook can be used by drivers to add ioctls to the *.init = and >> =A0*.lock devices. This commit breaks the ttydevsw ABI, since this > >Aren't __FreeBSD_version bumps cheap, these days? A __FreeBSD_version bump can help a driver determine whether specific functionality is available in the kernel but that doesn't solve this particular issue. A struct ttydevsw is allocated and populated by a TTY device driver and passed to the generic TTY code to define callbacks from the generic code into the driver. Consider the case where a module compiled with an old struct ttydevsw definition is loaded into a new kernel - the generic TTY code will attempt to reference ttydevsw fields that aren't defined by the driver, with results that won't be pretty. --=20 Peter Jeremy --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iEYEARECAAYFAk4PmtAACgkQ/opHv/APuIeX8QCfZHpQ6DnaY55zRfjddq/S3sRw mW4An23PaaPTgA1ZIx393g78U+BQVYEv =ZXJy -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110702222520.GA28815>