Date: Mon, 3 Jul 1995 11:10:45 -0500 (CDT) From: Mike Pritchard <mpp@legarto.minn.net> To: imb@scgt.oz.au (michael butler) Cc: current@freebsd.org Subject: Re: spontaneous reboots ? Message-ID: <199507031610.LAA00793@mpp.com> In-Reply-To: <199507031529.BAA02503@asstdc.scgt.oz.au> from "michael butler" at Jul 4, 95 01:29:13 am
next in thread | previous in thread | raw e-mail | index | archive | help
I just filed a PR (with a patch) on this very problem just last
night. It is PR kern/585. I saw panics, and not spontaneous reboots.
> I wrote:
>
> > It's in the ipfw code ..
>
> In ip_fw.c at about line 300:
>
> > bad_packet:
> > if (f) {
> > /*
> > * Do not ICMP reply to icmp
> > * packets....:)
> > */
> > if (f_prt==IP_FW_F_ICMP)
> > goto return_0;
>
> *** NOTE "m" is still uninitialised here ***
>
> > /*
> > * Reply to packets rejected
> > * by entry with this flag
> > * set only.
> > */
> > if (!(f->fw_flg&IP_FW_F_ICMPRPL))
> > goto return_0;
>
> *** and here ***
>
> > m = dtom(ip);
>
> :
> :
>
> > return_0:
> > m_freem(m);
> > return 0;
> > good_packet:
> > return 1;
> > }
>
> .. but we try m_freem(m) anyway ?
>
> michael
--
Mike Pritchard
mpp@legarto.minn.net
"Go that way. Really fast. If something gets in your way, turn"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507031610.LAA00793>